From bfc9a39fd6b5454caa3409a564261d634902a02b Mon Sep 17 00:00:00 2001 From: Matt Graham Date: Fri, 13 Dec 2024 13:17:15 +0000 Subject: [PATCH] Indicate cubic memory overhead in generate_precomputes docstring --- s2fft/recursions/price_mcewen.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/s2fft/recursions/price_mcewen.py b/s2fft/recursions/price_mcewen.py index 8d4f1037..f9aa8f95 100644 --- a/s2fft/recursions/price_mcewen.py +++ b/s2fft/recursions/price_mcewen.py @@ -21,9 +21,11 @@ def generate_precomputes( L_lower: int = 0, ) -> List[np.ndarray]: r""" - Compute recursion coefficients with :math:`\mathcal{O}(L^2)` memory overhead. - In practice one could compute these on-the-fly but the memory overhead is - negligible and well worth the acceleration. + Compute recursion coefficients with :math:`\mathcal{O}(L^3)` memory overhead. + + The corresponding JAX implementation in :py:func:`generate_precomputes_jax` has a + :math:`\mathcal{O}(L^2)` overhead and so should generally be preferred, particularly + for large :math:`L`. Args: L (int): Harmonic band-limit.