Skip to content

Indicate cubic memory overhead in generate_precomputes docstring #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matt-graham merged 1 commit into from
Dec 18, 2024
Merged

Indicate cubic memory overhead in generate_precomputes docstring #257

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions s2fft/recursions/price_mcewen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,11 @@ def generate_precomputes(
L_lower: int = 0,
) -> List[np.ndarray]:
r"""
Compute recursion coefficients with :math:`\mathcal{O}(L^2)` memory overhead.
In practice one could compute these on-the-fly but the memory overhead is
negligible and well worth the acceleration.
Compute recursion coefficients with :math:`\mathcal{O}(L^3)` memory overhead.

The corresponding JAX implementation in :py:func:`generate_precomputes_jax` has a
:math:`\mathcal{O}(L^2)` overhead and so should generally be preferred, particularly
for large :math:`L`.

Args:
L (int): Harmonic band-limit.
Expand Down
Loading