Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions s2fft/sampling/so3_samples.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ def f_shape(
:math:`SO(3)`.

Note:
Importantly, the convention adopted for storage of f is :math:`[\beta, \alpha,
\gamma]`, for Euler angles :math:`(\alpha, \beta, \gamma)` following the
Importantly, the convention adopted for storage of :math:`f` is :math:`[\gamma,
\beta, \alpha]`, for Euler angles :math:`(\alpha, \beta, \gamma)` following the
:math:`zyz` Euler convention, in order to simplify indexing for internal use.
For a given :math:`\gamma` we thus recover a signal on the sphere indexed by
:math:`[\theta, \phi]`, i.e. we associate :math:`\beta` with :math:`\theta` and
Expand Down
10 changes: 5 additions & 5 deletions s2fft/utils/signal_generator.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,11 @@ def complex_el_and_m_indices(L: int, min_el: int) -> tuple[np.ndarray, np.ndarra

Equivalent to nested list-comprehension based implementation

```
el_indices, m_indices = np.array(
[(el, m) for el in range(min_el, L) for m in range(1, el + 1)]
).T
```
.. code-block:: python

el_indices, m_indices = np.array(
[(el, m) for el in range(min_el, L) for m in range(1, el + 1)]
).T

For `L, min_el = 1024, 0`, this implementation is around 80x quicker in
benchmarks compared to list-comprehension implementation.
Expand Down
Loading