Use separate jobs and environment for PyPI and Test PyPI uploading #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-graham
added
the
infrastructure
Collaborator
Author
|
Merging this without review as per internal discussion as this should only affect release workflow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #259
Separates current combined Actions workflow job for uploading to both Test PyPI and PyPI in to separate jobs each with their own dedicated environment, to avoid the issue with attestation file from Test PyPI upload causing PyPI upload to subsequently fail, with runs in separate jobs instead being in isolated environments. This also seems to be the recommended practice .