Skip to content

Conversation

@matt-graham
Copy link
Collaborator

May resolve #292

An initial attempt at fixing the issues in building fftw as part of building wheels for pyssht and so3 by defining an environment variable CMAKE_POLICY_VERSION_MINIMUM=3.5 as recommended in associated CMake error.

Also applies similar change to #284 in actions/checkout step in publish workflow to tests workflow to ensure tags are checked out and so setuptools_scm correctly infers package version when building / installing s2fft.

@codecov
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.29%. Comparing base (6d55715) to head (33bcbd8).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #293   +/-   ##
=======================================
  Coverage   96.29%   96.29%           
=======================================
  Files          31       31           
  Lines        3586     3586           
=======================================
  Hits         3453     3453           
  Misses        133      133           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matt-graham matt-graham merged commit 1d5fa15 into main Apr 3, 2025
14 checks passed
@matt-graham matt-graham deleted the mmg/fftw-build-errors branch April 3, 2025 08:22
@matt-graham matt-graham added the github_actions Pull requests that update GitHub Actions code label Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests failing due to issues building wheels for so3 and pyssht

2 participants