Replace homegrown build options with standard

- tests -> BUILD_TESTING
- fPIC -> CMAKE_POSITION_INDEPENDENT_CODE

Author: mdavezac

CMakeLists.txt

@@ -6,11 +6,7 @@ project(
   HOMEPAGE_URL "http://astro-informatics.github.io/so3/"
   LANGUAGES C)
 
-option(tests "Enable testing" ON)
 option(conan_deps "Download ssht using conan" ON)
-if(NOT WIN32)
-  option(fPIC "Enable position independent code" ON)
-endif()
 if(conan_deps AND download_ssht)
   message(
     FATAL_ERROR "conan_deps and download_ssht options are mutually exclusive.")
@@ -20,9 +16,7 @@ if(NOT CMAKE_BUILD_TYPE)
   set(CMAKE_BUILD_TYPE "Debug")
 endif()
 
-if(tests)
-  enable_testing()
-endif()
+include(CTest)
 if(conan_deps OR CONAN_EDITABLE_MODE)
   include("${PROJECT_SOURCE_DIR}/cmake/conan_dependencies.cmake")
 endif()
@@ -41,7 +35,7 @@ find_package(FFTW3 REQUIRED)
 find_library(MATH_LIBRARY m)
 
 add_subdirectory(src/c)
-if(tests)
+if(BUILD_TESTING)
   include("${PROJECT_SOURCE_DIR}/cmake/fetch_cmocka.cmake")
   add_subdirectory(tests)
 endif()

setup.py

@@ -1,6 +1,10 @@
 from skbuild import setup
 
-cmake_args = ["-Dtests:BOOL=OFF", "-Dconan_deps=ON", "-DfPIC=ON"]
+cmake_args = [
+    "-DBUILD_TESTING:BOOL=OFF",
+    "-Dconan_deps=ON",
+    "-DCMAKE_POSITION_INDEPENDENT_CODE=ON",
+]
 
 setup(
     name="so3",

src/c/CMakeLists.txt

@@ -11,10 +11,6 @@ target_compile_features(so3 PUBLIC c_std_99)
 configure_file(${PROJECT_SOURCE_DIR}/include/so3/so3_version.in.h
                ${PROJECT_BINARY_DIR}/include/so3/so3_version.h)
 
-if(fPIC)
-  set_target_properties(so3 PROPERTIES POSITION_INDEPENDENT_CODE TRUE)
-endif()
-
 if(NOT SKBUILD)
   install(
     TARGETS so3