Add /var/lib/nginx/logs for chainguard nginx (#689)

* Add /var/lib/nginx/logs for chainguard nginx

* v1.17.19

* add dagserver volume

* add git-sync volume

* add {"name": "nginx-access-logs", "emptyDir": {}}, volume

* fix test

* dagserver sts test fix

---------

Co-authored-by: Shubham-astro <shubham.singh@astronomer.io>

Author: danielhoherd

Chart.yaml

@@ -1,7 +1,7 @@
 # apiVersion v2 is Helm 3
 apiVersion: v2
 name: airflow
-version: 1.17.18
+version: 1.17.19
 description: Helm chart to deploy the Astronomer Platform Airflow module
 icon: https://airflow.apache.org/docs/apache-airflow/stable/_images/pin_large.png
 keywords:

templates/_helpers.yaml

@@ -431,6 +431,8 @@ Create the name of the cleanup service account to use
     periodSeconds: 10
 {{- end }}
   volumeMounts:
+  - mountPath: /var/lib/nginx/logs
+    name: nginx-access-logs
   - mountPath: /etc/nginx/nginx.conf
     name: nginx-sidecar-conf
     subPath: nginx.conf

templates/dag-deploy/dag-server-statefulset.yaml

@@ -130,6 +130,8 @@ spec:
         name: nginx-cache
       - emptyDir: {}
         name: nginx-tmp
+      - name: nginx-access-logs
+        emptyDir: {}
 {{- end }}
 {{- if .Values.loggingSidecar.enabled }}
       - name: config-volume

templates/git-sync-relay/git-sync-relay-deployment.yaml

@@ -69,6 +69,8 @@ spec:
           name: sidecar-logging-consumer
         {{- end }}
         {{- if and .Values.authSidecar.enabled (eq .Values.gitSyncRelay.repoFetchMode "webhook") }}
+        - name: nginx-access-logs
+          emptyDir: {}
         - name: nginx-sidecar-conf
           configMap:
             name: {{ .Release.Name }}-git-sync-relay-nginx-conf

tests/chart/test_dag_server_statefulset.py

@@ -297,6 +297,7 @@ def test_dag_server_statefulset_with_probes_and_authproxy_enabled(self, kube_ver
             {"name": "nginx-sidecar-conf", "configMap": {"name": "release-name-dag-server-nginx-conf"}},
             {"name": "nginx-cache", "emptyDir": {}},
             {"name": "nginx-tmp", "emptyDir": {}},
+            {"name": "nginx-access-logs", "emptyDir": {}},
             {"name": "config-volume", "configMap": {"name": "release-name-sidecar-config"}},
             {"name": "sidecar-logging-consumer", "emptyDir": {}},
         ]
@@ -312,6 +313,7 @@ def test_dag_server_statefulset_with_probes_and_authproxy_enabled(self, kube_ver
         assert livenessProbe == c_by_name["sidecar-log-consumer"]["livenessProbe"]
 
         assert c_by_name["auth-proxy"]["volumeMounts"] == [
+            {"mountPath": "/var/lib/nginx/logs", "name": "nginx-access-logs"},
             {"mountPath": "/etc/nginx/nginx.conf", "name": "nginx-sidecar-conf", "subPath": "nginx.conf"},
             {"mountPath": "/var/cache/nginx", "name": "nginx-cache"},
             {"mountPath": "/tmp", "name": "tmp"},  # noqa: S108

tests/chart/test_git_sync_relay_deployment.py

@@ -333,6 +333,7 @@ def test_git_sync_server_deployment_with_sidecar_and_authproxy_enabled(self, kub
             {"name": "release-name-git-sync-config", "configMap": {"name": "release-name-git-sync-config"}},
             {"name": "config-volume", "configMap": {"name": "release-name-sidecar-config"}},
             {"name": "sidecar-logging-consumer", "emptyDir": {}},
+            {"name": "nginx-access-logs", "emptyDir": {}},
             {"name": "nginx-sidecar-conf", "configMap": {"name": "release-name-git-sync-relay-nginx-conf"}},
             {"name": "nginx-cache", "emptyDir": {}},
             {"name": "nginx-tmp", "emptyDir": {}},
@@ -352,6 +353,7 @@ def test_git_sync_server_deployment_with_sidecar_and_authproxy_enabled(self, kub
         ]
 
         assert c_by_name["auth-proxy"]["volumeMounts"] == [
+            {"mountPath": "/var/lib/nginx/logs", "name": "nginx-access-logs"},
             {"mountPath": "/etc/nginx/nginx.conf", "name": "nginx-sidecar-conf", "subPath": "nginx.conf"},
             {"mountPath": "/var/cache/nginx", "name": "nginx-cache"},
             {"mountPath": "/tmp", "name": "tmp"},  # noqa: S108