Skip to content

Commit 8bfd7f1

Browse files
authored
Migrate remaining providers to common.compat compatibility layer in Salesforce (apache#57088)
* Migrate remaining providers to common.compat compatibility layer * remove extra modification * fix ruff error
1 parent cfa11c9 commit 8bfd7f1

File tree

5 files changed

+11
-18
lines changed

5 files changed

+11
-18
lines changed

providers/salesforce/pyproject.toml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ requires-python = ">=3.10"
5858
# After you modify the dependencies, and rebuild your Breeze CI image with ``breeze ci-image build``
5959
dependencies = [
6060
"apache-airflow>=2.10.0",
61+
"apache-airflow-providers-common-compat>=1.7.4", # + TODO: bump to next version
6162
"simple-salesforce>=1.0.0",
6263
'pandas>=2.1.2; python_version <"3.13"',
6364
'pandas>=2.2.3; python_version >="3.13"',
@@ -68,6 +69,7 @@ dev = [
6869
"apache-airflow",
6970
"apache-airflow-task-sdk",
7071
"apache-airflow-devel-common",
72+
"apache-airflow-providers-common-compat",
7173
# Additional devel dependencies (do not remove this line and add extra development dependencies)
7274
]
7375

providers/salesforce/src/airflow/providers/salesforce/hooks/salesforce.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232

3333
from simple_salesforce import Salesforce, api
3434

35-
from airflow.providers.salesforce.version_compat import BaseHook
35+
from airflow.providers.common.compat.sdk import BaseHook
3636

3737
if TYPE_CHECKING:
3838
import pandas as pd

providers/salesforce/src/airflow/providers/salesforce/operators/bulk.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,15 @@
1919
from collections.abc import Iterable
2020
from typing import TYPE_CHECKING, cast
2121

22+
from airflow.providers.common.compat.sdk import BaseOperator
2223
from airflow.providers.salesforce.hooks.salesforce import SalesforceHook
23-
from airflow.providers.salesforce.version_compat import BaseOperator
2424

2525
if TYPE_CHECKING:
2626
from typing import Literal
2727

2828
from simple_salesforce.bulk import SFBulkHandler
2929

30-
from airflow.providers.salesforce.version_compat import Context
30+
from airflow.providers.common.compat.sdk import Context
3131

3232

3333
class SalesforceBulkOperator(BaseOperator):

providers/salesforce/src/airflow/providers/salesforce/operators/salesforce_apex_rest.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,11 @@
1818

1919
from typing import TYPE_CHECKING
2020

21+
from airflow.providers.common.compat.sdk import BaseOperator
2122
from airflow.providers.salesforce.hooks.salesforce import SalesforceHook
22-
from airflow.providers.salesforce.version_compat import BaseOperator
2323

2424
if TYPE_CHECKING:
25-
from airflow.providers.salesforce.version_compat import Context
25+
from airflow.providers.common.compat.sdk import Context
2626

2727

2828
class SalesforceApexRestOperator(BaseOperator):

providers/salesforce/src/airflow/providers/salesforce/version_compat.py

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -30,16 +30,7 @@ def get_base_airflow_version_tuple() -> tuple[int, int, int]:
3030
AIRFLOW_V_3_0_PLUS = get_base_airflow_version_tuple() >= (3, 0, 0)
3131
AIRFLOW_V_3_1_PLUS: bool = get_base_airflow_version_tuple() >= (3, 1, 0)
3232

33-
if AIRFLOW_V_3_0_PLUS:
34-
from airflow.sdk import BaseOperator
35-
from airflow.sdk.definitions.context import Context
36-
else:
37-
from airflow.models import BaseOperator
38-
from airflow.utils.context import Context
39-
40-
if AIRFLOW_V_3_1_PLUS:
41-
from airflow.sdk import BaseHook
42-
else:
43-
from airflow.hooks.base import BaseHook # type: ignore[attr-defined,no-redef]
44-
45-
__all__ = ["AIRFLOW_V_3_0_PLUS", "BaseHook", "BaseOperator", "Context"]
33+
__all__ = [
34+
"AIRFLOW_V_3_0_PLUS",
35+
"AIRFLOW_V_3_1_PLUS",
36+
]

0 commit comments

Comments
 (0)