Skip to content

Conversation

@delucchi-cmu
Copy link
Contributor

Came up during the CMU hackathon

@delucchi-cmu delucchi-cmu requested a review from hombit September 5, 2025 17:31
@github-actions
Copy link

github-actions bot commented Sep 5, 2025

Before [a77f903] After [a63f7fc] Ratio Benchmark (Parameter)
failed failed n/a benchmarks.time_lazy_crossmatch_many_columns_all_suffixes
failed failed n/a benchmarks.time_lazy_crossmatch_many_columns_overlapping_suffixes
failed failed n/a benchmarks.time_open_many_columns_all
39.8±0.4ms 41.0±3ms 1.03 benchmarks.time_polygon_search
24.9±0.08ms 25.1±0.3ms 1.01 benchmarks.time_box_filter_on_partition
867±5ms 874±3ms 1.01 benchmarks.time_create_midsize_catalog
90.7±0.9ms 91.0±2ms 1.00 benchmarks.time_kdtree_crossmatch
1.69±0.07s 1.69±0.05s 1.00 benchmarks.time_open_many_columns_default
579±9ms 581±5ms 1.00 benchmarks.time_open_many_columns_list
5.83±0s 5.79±0.01s 0.99 benchmarks.time_create_large_catalog

Some benchmarks failed or their performance regressed significantly.

@codecov
Copy link

codecov bot commented Sep 5, 2025

Codecov Report

❌ Patch coverage is 82.60870% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.96%. Comparing base (a77f903) to head (14275cc).

Files with missing lines Patch % Lines
src/lsdb/io/to_map.py 82.60% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1004      +/-   ##
==========================================
- Coverage   97.20%   96.96%   -0.25%     
==========================================
  Files          46       47       +1     
  Lines        2723     2769      +46     
==========================================
+ Hits         2647     2685      +38     
- Misses         76       84       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants