Change catalog_names to catalog_labels for consistency

Author: mwcraig

src/astro_image_display_api/api_test.py

@@ -79,8 +79,8 @@ def _assert_empty_catalog_table(self, table):
         assert len(table) == 0
         assert sorted(table.colnames) == sorted(["x", "y", "coord"])
 
-    def _get_catalog_names_as_set(self):
-        marks = self.image.catalog_names
+    def _get_catalog_labels_as_set(self):
+        marks = self.image.catalog_labels
         return set(marks)
 
     @pytest.mark.parametrize("load_type", ["fits", "nddata", "array"])
@@ -489,7 +489,7 @@ def test_load_multiple_catalogs(self, catalog):
             catalog_label="test2",
         )
 
-        assert sorted(self.image.catalog_names) == ["test1", "test2"]
+        assert sorted(self.image.catalog_labels) == ["test1", "test2"]
 
         # No guarantee markers will come back in the same order, so sort them.
         t1 = self.image.get_catalog(catalog_label="test1")
@@ -513,7 +513,7 @@ def test_load_multiple_catalogs(self, catalog):
         # other one without a label.
         self.image.remove_catalog(catalog_label="test1")
         # Make sure test1 is really gone.
-        assert self.image.catalog_names == ("test2",)
+        assert self.image.catalog_labels == ("test2",)
 
         # Get without a catalog
         t2 = self.image.get_catalog()

src/astro_image_display_api/image_viewer_logic.py

@@ -590,7 +590,7 @@ def get_catalog(
         return result
 
     @property
-    def catalog_names(self) -> tuple[str, ...]:
+    def catalog_labels(self) -> tuple[str, ...]:
         return tuple(self._user_catalog_labels())
 
     # Methods that modify the view

src/astro_image_display_api/interface_definition.py

@@ -543,7 +543,7 @@ def get_catalog(
 
     @property
     @abstractmethod
-    def catalog_names(self) -> tuple[str, ...]:
+    def catalog_labels(self) -> tuple[str, ...]:
         """
         Names of the loaded catalogs.