Skip to content

Commit 9a04a5b

Browse files
committed
Fix minor errors in test logic
1 parent 57a04dc commit 9a04a5b

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/astro_image_display_api/widget_api_test.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,7 @@ def test_marking_operations(self):
142142

143143
# Set the marker style
144144
marker_style = {'color': 'yellow', 'radius': 10, 'type': 'cross'}
145+
self.image.marker = marker_style
145146
m_str = str(self.image.marker)
146147
for key in marker_style.keys():
147148
assert key in m_str
@@ -314,14 +315,13 @@ def test_adding_markers_as_world(self, data, wcs):
314315
# Add markers using world coordinates
315316
pixels = np.linspace(0, 100, num=10).reshape(5, 2)
316317
marks_pix = Table(data=pixels, names=['x', 'y'], dtype=('float', 'float'))
317-
marks_world = wcs.pixel_to_world(marks_pix['x'], marks_pix['y'])
318-
marks_coords = SkyCoord(marks_world, unit='degree')
318+
marks_coords = wcs.pixel_to_world(marks_pix['x'], marks_pix['y'])
319319
mark_coord_table = Table(data=[marks_coords], names=['coord'])
320320
self.image.add_markers(mark_coord_table, use_skycoord=True)
321321
result = self.image.get_markers()
322322
# Check the x, y positions as long as we are testing things...
323323
# The first test had one entry that was zero, so any check
324-
# based on rtol will will. Added a small atol to make sure
324+
# based on rtol will not work. Added a small atol to make sure
325325
# the test passes.
326326
np.testing.assert_allclose(result['x'], marks_pix['x'], atol=1e-9)
327327
np.testing.assert_allclose(result['y'], marks_pix['y'])
@@ -336,7 +336,7 @@ def test_stretch(self):
336336

337337
original_stretch = self.image.stretch
338338

339-
with pytest.raises(ValueError, match='must be one of'):
339+
with pytest.raises(ValueError, match='[mM]ust be one of'):
340340
self.image.stretch = 'not a valid value'
341341

342342
# A bad value should leave the stretch unchanged
@@ -347,7 +347,7 @@ def test_stretch(self):
347347
assert self.image.stretch is not original_stretch
348348

349349
def test_cuts(self, data):
350-
with pytest.raises(ValueError, match='must be one of'):
350+
with pytest.raises(ValueError, match='[mM]ust be one of'):
351351
self.image.cuts = 'not a valid value'
352352

353353
with pytest.raises(ValueError, match='must have length 2'):

0 commit comments

Comments
 (0)