Remove image_height and image_width

Author: mwcraig

src/astro_image_display_api/api_test.py

@@ -18,12 +18,14 @@
 
 __all__ = ["ImageAPITest"]
 
+DEFAULT_IMAGE_SHAPE = (100, 150)
+
 
 class ImageAPITest:
     @pytest.fixture
     def data(self):
         rng = np.random.default_rng(1234)
-        return rng.random((100, 150))
+        return rng.random(DEFAULT_IMAGE_SHAPE)
 
     @pytest.fixture
     def wcs(self):
@@ -49,8 +51,8 @@ def catalog(self, wcs: WCS) -> Table:
         expected columns.
         """
         rng = np.random.default_rng(45328975)
-        x = rng.uniform(0, self.image.image_width, size=10)
-        y = rng.uniform(0, self.image.image_height, size=10)
+        x = rng.uniform(0, DEFAULT_IMAGE_SHAPE[0], size=10)
+        y = rng.uniform(0, DEFAULT_IMAGE_SHAPE[1], size=10)
         coord = wcs.pixel_to_world(x, y)
 
         cat = Table(
@@ -70,7 +72,7 @@ def setup(self):
         Subclasses MUST define ``image_widget_class`` -- doing so as a
         class variable does the trick.
         """
-        self.image = self.image_widget_class(image_width=250, image_height=100)
+        self.image = self.image_widget_class()
 
     def _assert_empty_catalog_table(self, table):
         assert isinstance(table, Table)
@@ -81,17 +83,6 @@ def _get_catalog_names_as_set(self):
         marks = self.image.catalog_names
         return set(marks)
 
-    def test_width_height(self):
-        assert self.image.image_width == 250
-        assert self.image.image_height == 100
-
-        width = 200
-        height = 300
-        self.image.image_width = width
-        self.image.image_height = height
-        assert self.image.image_width == width
-        assert self.image.image_height == height
-
     @pytest.mark.parametrize("load_type", ["fits", "nddata", "array"])
     def test_load(self, data, tmp_path, load_type):
         match load_type:

src/astro_image_display_api/image_viewer_logic.py

@@ -60,12 +60,6 @@ class ImageViewerLogic:
     state to simulate the behavior of a real viewer.
     """
 
-    # These are attributes, not methods. The type annotations are there
-    # to make sure Protocol knows they are attributes. Python does not
-    # do any checking at all of these types.
-    image_width: int = 0
-    image_height: int = 0
-    zoom_level: float = 1
     _cuts: BaseInterval | tuple[float, float] = AsymmetricPercentileInterval(
         upper_percentile=95
     )

src/astro_image_display_api/interface_definition.py

@@ -15,12 +15,6 @@
 
 @runtime_checkable
 class ImageViewerInterface(Protocol):
-    # These are attributes, not methods. The type annotations are there
-    # to make sure Protocol knows they are attributes. Python does not
-    # do any checking at all of these types.
-    image_width: int
-    image_height: int
-
     # The methods, grouped loosely by purpose
 
     # Method for loading image data