Add get_image and get_image_label #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwcraig
requested changes
Jun 30, 2025
Member
mwcraig
left a comment
mwcraig
left a comment
There was a problem hiding this comment.
Thanks -- comments are inline.
| assert isinstance(self.image.get_image_labels(), tuple) | ||
|
|
||
| self.image.load_image(data, image_label="test") | ||
| assert len(self.image.get_image_labels()) == 2 |
Member
There was a problem hiding this comment.
Interesting; logically I would have thought of this as being 1.
Is this too complicated: None only counts as an image label if it has data associated with it
So the idea would be that if, like in this example, the only loaded data was for an image label you set, the get_image_labels returns just the image label you have used.
Doing this would return two image labels:
# Assume we are starting with a clean slate
assert self.image.get_image_labels() is None # or maybe == []
# Load an image without a label, which means the label is `None`
self.image.load_image(data)
# Load a second image with an explicit label
self.image.load_image(data, label="test")
assert len(self.image.get_image_labels()) == 2 # None and "test"
mwcraig
approved these changes
Jul 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @mwcraig at the coordination meeting. For now we are setting no type limitations on the returned image since backends often have different internal representations.
Edit: fixes #59