Add test for and fix bug in viewer logic #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bug was that the second time loda_cagatalog is called without a style argument the style gets set to None instead of the default style.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where calling load_catalog a second time without specifying a style would reset the catalog’s style to None, and adds a test to verify default style assignment.
- Fix
load_catalogto preserve an existing catalog style when no new style is provided - Add
test_catalog_has_style_after_loadingto ensure default styling is applied and persists - Minor formatting adjustment (blank line removal/addition)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/astro_image_display_api/image_viewer_logic.py | Adjust load_catalog logic to reuse existing style if present |
| src/astro_image_display_api/api_test.py | Add a new test (test_catalog_has_style_after_loading) |
Comments suppressed due to low confidence (2)
src/astro_image_display_api/api_test.py:441
- Add a test case where a custom style is provided on the first
load_catalogcall, then verify that a subsequent call without a style argument does not overwrite the custom style.
def test_catalog_has_style_after_loading(self, catalog):
src/astro_image_display_api/image_viewer_logic.py:527
- [nitpick] Align the comment indentation exactly with the surrounding code block to match project style (4 spaces under the
if), improving readability.
# No style has been set, so use the default style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was that the second time load_cagatalog is called without a style argument the style gets set to None instead of the default style.