get_skycoord: improve performance by continuing to ignore non-scalar SkyCoord targets when checking for multiple targets

Author: michaelbaisch

astroplan/observer.py

@@ -518,10 +518,7 @@ def _preprocess_inputs(self, time, target=None, grid_times_targets=False):
             return time, None
 
         # Remember whether target is a single time-dependent target
-        is_multiple_targets = (
-            isinstance(target, (list, tuple)) or
-            (isinstance(target, SkyCoord) and not target.isscalar)
-        )
+        is_multiple_targets = isinstance(target, (list, tuple))
         is_target_time_dependent = (
             callable(getattr(target, "get_skycoord", None)) and not
             hasattr(target, "coord")

astroplan/target.py

@@ -422,10 +422,9 @@ def _as_coord(obj):
             return obj.get_skycoord(times)
         return obj
 
-    is_multiple_targets = (
-        isinstance(targets, (list, tuple)) or
-        (isinstance(targets, SkyCoord) and not targets.isscalar)
-    )
+    # Ignore non-scalar SkyCoords targets here
+    # e.g. from get_body/get_sun, because they represent a single target
+    is_multiple_targets = isinstance(targets, (list, tuple))
     if not is_multiple_targets:
         return _as_coord(targets)