Skip to content

Commit 1573094

Browse files
eteqhamogu
andauthored
Apply @hamogu minor suggestions from code review
Co-authored-by: Hans Moritz Günther <[email protected]>
1 parent 0e2dc69 commit 1573094

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

messages/maintainer_access.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ Hello {NAME},
22

33
You have been nominated as {role} and the Coordinating Committee has enthusiastically accepted this nomination! We would be thrilled if you are able to accept this nomination. {More context might be necessary for some people - fill it in here}
44

5-
In case you are not familiar with the role, maintainers are the people who keep a package or sub-package working. In particular, they review and merge PRs, keep track of what's going on and organize ideas for future development (see https://www.astropy.org/team.html#Subpackage_maintainer for details). In practice this means a fair amount of community interaction when reviewing PRs and related discussion. As a general guideline, if you have any uncertainty or if there is extended debate about merging a PR, seek consensus from other maintainers in the Project. If necessary, you should also real free to reach out to the Coordination Committee (by @-mention on github or via [email protected]), as the Coordination Committee has the authority to make decisions when consensus cannot be acheived.
5+
In case you are not familiar with the role, maintainers are the people who keep a package or sub-package working. In particular, they review and merge PRs, keep track of what's going on and organize ideas for future development (see https://www.astropy.org/team.html#Subpackage_maintainer for details). In practice this means a fair amount of community interaction when reviewing PRs and related discussion. As a general guideline, if you have any uncertainty or if there is extended debate about merging a PR, seek consensus from other maintainers in the Project. If necessary, you should also free to reach out to the Coordination Committee (by @-mention on github or via [email protected]), as the Coordination Committee has the authority to make decisions when consensus cannot be achieved.
66

77
If you would like to accept this nomination, we ask that you familiarize yourself with the following Project guidelines:
88

policies/adding-new-role-members.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
This document describes the process for adding new people to named roles. This
2-
document is *not* about how people are nominated for a rolein the first place,
2+
document is *not* about how people are nominated for a role in the first place,
33
but rather the process by which they are added once nominated. The
44
process itself is in the hands of the Coordination Committee according to
55
[APE0](https://github.com/astropy/astropy-APEs/blob/main/APE0.rst).
@@ -30,7 +30,6 @@ The process is:
3030
final decision based on any feedback.
3131
6. If the appointment is confirmed, the nominee is added to the roles page
3232
(i.e., the PR created in step 4 can be merged).
33-
7. If a maintainer, the nominee receives the necessary Github or other
34-
permissions.
33+
7. The nominee receives the necessary Github or other permissions for the new role.
3534
8. The Coordination Committee member sends a confirmation message to the nominee
3635
to complete the process.

0 commit comments

Comments
 (0)