Skip to content

Commit 5be273b

Browse files
authored
Merge pull request #206 from eteq/write-up-maintainer-process
Write up process of nominating members of roles
2 parents 981fbd7 + de8a63a commit 5be273b

File tree

3 files changed

+56
-16
lines changed

3 files changed

+56
-16
lines changed

messages/core_write_access.md

Lines changed: 0 additions & 16 deletions
This file was deleted.

messages/maintainer_access.md

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
Hello {NAME},
2+
3+
You have been nominated as {role} and the Coordinating Committee has enthusiastically accepted this nomination! We would be thrilled if you are able to accept this nomination. {More context might be necessary for some people - fill it in here}
4+
5+
In case you are not familiar with the role, maintainers are the people who keep a package or sub-package working. In particular, they review and merge PRs, keep track of what's going on and organize ideas for future development (see https://www.astropy.org/team.html#Subpackage_maintainer for details). In practice this means a fair amount of community interaction when reviewing PRs and related discussion. As a general guideline, if you have any uncertainty or if there is extended debate about merging a PR, seek consensus from other maintainers in the Project. If necessary, you should also free to reach out to the Coordination Committee (by @-mention on github or via [email protected]), as the Coordination Committee has the authority to make decisions when consensus cannot be achieved.
6+
7+
If you would like to accept this nomination, we ask that you familiarize yourself with the following Project guidelines:
8+
9+
* [Developer guidelines for Astropy](https://docs.astropy.org/en/latest/#developer-documentation)
10+
* [Basic development workflow](https://docs.astropy.org/en/latest/development/workflow/development_workflow.html)
11+
* [Guidelines on when to squash or rebase](https://docs.astropy.org/en/latest/development/when_to_rebase.html)
12+
* [Astropy Project Code of Conduct](https://www.astropy.org/code_of_conduct.html)
13+
14+
If you accept, please respond indicating that you've reviewed the developer documentation and that you have read and agree to abide by the Code of Conduct. After we receive that email from you, we will make an announcement and there will be a two week period of comment. After that period is over, your name will be added to the team webpage and you will be given the appropriate Github permissions.
15+
16+
If you are not already, we also enourage you to join the [astropy-dev mailing list](https://groups.google.com/g/astropy-dev), and start trying to attend the monthly developer telecons.
17+
18+
Congratulations on the nomination and thanks for your contributions! We very much hope you accept it. We're very happy to answer any questions you may have about the role.
19+
20+
For the coordinating committee,
21+
{YOUR NAME}

policies/adding-new-role-members.md

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
1+
This document describes the process for adding new people to named roles. This
2+
document is *not* about how people are nominated for a role in the first place,
3+
but rather the process by which they are added once nominated. The
4+
process itself is in the hands of the Coordination Committee according to
5+
[APE0](https://github.com/astropy/astropy-APEs/blob/main/APE0.rst).
6+
7+
Note some of the steps below are highlighted as specific for maintainers.
8+
Maintainers are the people who keep a package or sub-package working. In
9+
particular, they review and merge PRs, keep track of what's going on and
10+
organize ideas for future development (see
11+
https://www.astropy.org/team.html#Subpackage_maintainer
12+
for details). Therefore, a maintainer requires particular Github permissions,
13+
which is highlighted in the process below.
14+
15+
The process is:
16+
17+
1. A Coordination Committee member sends a message to the person
18+
nominated, making sure they understand the role, its responsibilities, and
19+
confirming that the nominee agrees. Suggested text of that message is
20+
[here](https://github.com/astropy/astropy-project/blob/main/messages/maintainer_access.md).
21+
2. The nominee should also be asked (generally but not necessarily in the
22+
message above) to confirm they agree the Code of Conduct, and that they are
23+
aware of maintainer guidelines if the role is a maintainer role.
24+
3. If the nominee does not accept, the process stops here.
25+
4. If the nominee does accept, a message is sent to the community, starting
26+
a two-week clock on the feedback period [as required by APE0](https://github.com/astropy/astropy-APEs/blob/main/APE0.rst#responsibilities-and-authority).
27+
The Coordination Committee member overseeing the process should make a PR at
28+
this time adding the member to the roles page as a place for public comment.
29+
5. Once the two week period has elapsed, the coordination committee makes a
30+
final decision based on any feedback.
31+
6. If the appointment is confirmed, the nominee is added to the roles page
32+
(i.e., the PR created in step 4 can be merged).
33+
7. The nominee receives the necessary Github or other permissions for the new role.
34+
8. The Coordination Committee member sends a confirmation message to the nominee
35+
to complete the process.

0 commit comments

Comments
 (0)