Skip to content

Commit 75aee9a

Browse files
eteqadrnhamogu
authored
Apply suggestions from code review
Co-authored-by: Adrian Price-Whelan <[email protected]> Co-authored-by: Hans Moritz Günther <[email protected]>
1 parent 4c416ec commit 75aee9a

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

messages/maintainer_access.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Hello {NAME},
22

3-
You have been nominated as {role} and the Coordinating Committee enthusiastically accepted this nomination! We would be thrilled if you are able to accept this nomination. {More context might be necessary for some people - fill it in here}
3+
You have been nominated as {role} and the Coordinating Committee has enthusiastically accepted this nomination! We would be thrilled if you are able to accept this nomination. {More context might be necessary for some people - fill it in here}
44

55
You can see the formal description of the maintainers role at http://www.astropy.org/team.html. If you have any uncertainty or if there is extended debate about merging a PR, seek consensus from other maintainers in the Project, or if absolutely necessary, the Coordination Committee.
66

policies/adding-new-maintainers.md

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
1+
Maintainers are the people who keep a package or sub-package working. In particular, they review and merge PRs, keep track of what's going on and organize ideas for future development (see https://www.astropy.org/team.html#Subpackage_maintainer for details). Therefore, a maintainer usually has experience with a package e.g. through work they did themselves or by commenting and helping others to work on PRs in a package or sub-package. There is no formal minimum on the number of commits/PRs/etc. though, anyone can volunteer or be suggested as a maintainer following the process below.
2+
13
This document describes the process for adding new people to maintainer roles.
24
"Maintainer" here basically means any role with github write powers. The
35
process is in the hands of the Coordination Committee according to
4-
[APE0](https://github.com/astropy/astropy-APEs/blob/main/APE0.rst), which also
5-
requires the comment period. The process is:
6+
[APE0](https://github.com/astropy/astropy-APEs/blob/main/APE0.rst). The process is:
67

78
1. Either the Coordination Committee or any community member including the
89
nominee may nominate someone for a role via private or public email,
@@ -11,13 +12,13 @@ requires the comment period. The process is:
1112
nominated, making sure they understand the role, its responsibilities, and
1213
confirming that the nominee agrees. Suggested text of that message is
1314
[here](https://github.com/astropy/astropy-project/blob/main/messages/maintainer_access.md).
14-
3. If the nominee does not accept, the process stopps here.
15-
4. If the nominee does accept, a message goes out to the community, starting
15+
3. If the nominee does not accept, the process stops here.
16+
4. If the nominee does accept, a message is sent to the community, starting
1617
a two-week clock on the feedback period [as required by APE0](https://github.com/astropy/astropy-APEs/blob/main/APE0.rst#responsibilities-and-authority).
1718
The Coordination Committee member overseeing the process can make a PR at
1819
this time adding the member to the roles page as a place for public comment.
1920
5. Once the two week period has elapsed, the coordination committee makes a
20-
final decision based on any feedback. If the appointment is confirmed,
21-
6. The nominee is added to the roles page (i.e., the PR created in step 4 can
21+
final decision based on any feedback.
22+
6. If the appointment is confirmed, the nominee is added to the roles page (i.e., the PR created in step 4 can
2223
be merged), and the nominee receives the necessary Github or other
2324
permissions and a confirmation message to complete the process.

0 commit comments

Comments
 (0)