Remove failed connection handler from esa.hsa tests

Rerunning remote tests that have failed because of a connection failure
can be done with the `pytest-rerunfailures` plugin for `pytest`, so
custom code for handling that in `esa.hsa` can be safely removed.

Author: eerovaher

astroquery/esa/hsa/tests/test_hsa_remote.py

@@ -3,7 +3,6 @@
 import tarfile
 
 import pytest
-from requests.exceptions import ChunkedEncodingError
 
 from ..core import HSAClass
 
@@ -20,16 +19,6 @@
 
 @pytest.mark.remote_data
 class TestHSARemote:
-    retries = 2
-
-    def access_archive_with_retries(self, f, params):
-        for _ in range(self.retries):
-            try:
-                res = f(**params)
-                return res
-            except ChunkedEncodingError:
-                pass
-        return None
 
     def test_download_data_observation_pacs(self, tmp_path):
         obs_id = "1342191813"
@@ -41,9 +30,7 @@ def test_download_data_observation_pacs(self, tmp_path):
                       'download_dir': tmp_path}
         expected_res = Path(tmp_path, obs_id + ".tar")
         hsa = HSAClass()
-        res = self.access_archive_with_retries(hsa.download_data, parameters)
-        if res is None:
-            pytest.xfail(f"Archive broke the connection {self.retries} times, unable to test")
+        res = hsa.download_data(**parameters)
         assert Path(res) == expected_res
         assert Path(res).is_file()
         with tarfile.open(res) as tar:
@@ -64,9 +51,7 @@ def test_download_data_observation_pacs_filename(self, tmp_path):
                       'download_dir': tmp_path}
         expected_res = Path(tmp_path, fname + ".tar")
         hsa = HSAClass()
-        res = self.access_archive_with_retries(hsa.download_data, parameters)
-        if res is None:
-            pytest.xfail(f"Archive broke the connection {self.retries} times, unable to test")
+        res = hsa.download_data(**parameters)
         assert Path(res) == expected_res
         assert Path(res).is_file()
         with tarfile.open(res) as tar:
@@ -86,9 +71,7 @@ def test_download_data_observation_pacs_compressed(self, tmp_path):
                       'download_dir': tmp_path}
         expected_res = Path(tmp_path, obs_id + ".tgz")
         hsa = HSAClass()
-        res = self.access_archive_with_retries(hsa.download_data, parameters)
-        if res is None:
-            pytest.xfail(f"Archive broke the connection {self.retries} times, unable to test")
+        res = hsa.download_data(**parameters)
         assert Path(res) == expected_res
         assert Path(res).is_file()
         with tarfile.open(res) as tar:
@@ -107,9 +90,7 @@ def test_download_data_observation_spire(self, tmp_path):
                       'download_dir': tmp_path}
         expected_res = Path(tmp_path, obs_id + ".tar")
         hsa = HSAClass()
-        res = self.access_archive_with_retries(hsa.download_data, parameters)
-        if res is None:
-            pytest.xfail(f"Archive broke the connection {self.retries} times, unable to test")
+        res = hsa.download_data(**parameters)
         assert Path(res) == expected_res
         assert Path(res).is_file()
         with tarfile.open(res) as tar:
@@ -127,9 +108,7 @@ def test_download_data_postcard_pacs(self, tmp_path):
                       'download_dir': tmp_path}
         expected_res = Path(tmp_path, obs_id + ".jpg")
         hsa = HSAClass()
-        res = self.access_archive_with_retries(hsa.download_data, parameters)
-        if res is None:
-            pytest.xfail(f"Archive broke the connection {self.retries} times, unable to test")
+        res = hsa.download_data(**parameters)
         assert Path(res) == expected_res
         assert Path(res).is_file()
 
@@ -144,9 +123,7 @@ def test_download_data_postcard_pacs_filename(self, tmp_path):
                       'download_dir': tmp_path}
         expected_res = Path(tmp_path, fname + ".jpg")
         hsa = HSAClass()
-        res = self.access_archive_with_retries(hsa.download_data, parameters)
-        if res is None:
-            pytest.xfail(f"Archive broke the connection {self.retries} times, unable to test")
+        res = hsa.download_data(**parameters)
         assert Path(res) == expected_res
         assert Path(res).is_file()
 
@@ -159,9 +136,7 @@ def test_get_observation(self, tmp_path):
                       'download_dir': tmp_path}
         expected_res = Path(tmp_path, obs_id + ".tar")
         hsa = HSAClass()
-        res = self.access_archive_with_retries(hsa.get_observation, parameters)
-        if res is None:
-            pytest.xfail(f"Archive broke the connection {self.retries} times, unable to test")
+        res = hsa.get_observation(**parameters)
         assert Path(res) == expected_res
         assert Path(res).is_file()
         with tarfile.open(res) as tar:
@@ -178,8 +153,6 @@ def test_get_postcard(self, tmp_path):
                       'download_dir': tmp_path}
         expected_res = Path(tmp_path, obs_id + ".jpg")
         hsa = HSAClass()
-        res = self.access_archive_with_retries(hsa.get_postcard, parameters)
-        if res is None:
-            pytest.xfail(f"Archive broke the connection {self.retries} times, unable to test")
+        res = hsa.get_postcard(**parameters)
         assert Path(res) == expected_res
         assert Path(res).is_file()