Skip to content

Commit 06edfc2

Browse files
committed
Removing performance log and moving it to issue#632
1 parent fefc4bf commit 06edfc2

File tree

1 file changed

+0
-35
lines changed

1 file changed

+0
-35
lines changed

astroquery/vizier/core.py

Lines changed: 0 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -125,41 +125,6 @@ def _server_to_url(self, return_type='votable'):
125125
plain text: asu-txt
126126
"""
127127

128-
"""
129-
Quasi-private performance tests:
130-
It seems that these are dominated by table parsing time.
131-
%timeit m83tsv = Vizier.query_object_async('M83', return_type='asu-tsv', cache=False)
132-
1 loops, best of 3: 7.11 s per loop
133-
%timeit m83tsv = Vizier.query_object_async('M83', return_type='votable', cache=False)
134-
1 loops, best of 3: 6.79 s per loop
135-
%timeit m83tsv = Vizier.query_object_async('M83', return_type='asu-fits', cache=False)
136-
1 loops, best of 3: 6.21 s per loop
137-
%timeit m83tsv = Vizier.query_object_async('M83', return_type='asu-binfits', cache=False)
138-
1 loops, best of 3: 667 ms per loop
139-
Looks like this one led to a segfault on their system?
140-
141-
%timeit m83tsv = Vizier.query_object_async('M83', return_type='asu-txt', cache=False)
142-
1 loops, best of 3: 6.83 s per loop
143-
%timeit m83tsv = Vizier.query_object_async('M83', return_type='asu-tsv', cache=False)
144-
1 loops, best of 3: 6.8 s per loop
145-
146-
m83tsv = Vizier.query_object_async('M83', return_type='asu-tsv', cache=False)
147-
m83votable = Vizier.query_object_async('M83', return_type='votable', cache=False)
148-
m83fits = Vizier.query_object_async('M83', return_type='asu-fits', cache=False)
149-
m83txt = Vizier.query_object_async('M83', return_type='asu-txt', cache=False)
150-
#m83binfits = Vizier.query_object_async('M83', return_type='asu-binfits', cache=False)
151-
152-
# many of these are invalid tables
153-
%timeit fitstbls = fits.open(BytesIO(m83fits.content), ignore_missing_end=True)
154-
1 loops, best of 3: 541 ms per loop
155-
156-
%timeit tbls = parse_vizier_tsvfile(m83tsv.content)
157-
1 loops, best of 3: 1.35 s per loop
158-
159-
%timeit votbls = parse_vizier_votable(m83votable.content)
160-
1 loops, best of 3: 3.62 s per loop
161-
162-
"""
163128
# Only votable is supported now, but in case we try to support
164129
# something in the future we should disallow invalid ones.
165130
assert return_type in ('votable', 'asu-tsv', 'asu-fits',

0 commit comments

Comments
 (0)