Refactor: Made svo_fps optional kwargs keyword only

Author: nkphysics

astroquery/svo_fps/core.py

@@ -31,7 +31,7 @@ class SvoFpsClass(BaseQuery):
     SVO_MAIN_URL = conf.base_url
     TIMEOUT = conf.timeout
 
-    def data_from_svo(self, query, cache=True, timeout=None,
+    def data_from_svo(self, query, *, cache=True, timeout=None,
                       error_msg='No data found for requested query'):
         """Get data in response to the query send to SVO FPS.
         This method is not generally intended for users, but it can be helpful
@@ -128,7 +128,7 @@ def get_transmission_data(self, filter_id, **kwargs):
         error_msg = 'No filter found for requested Filter ID'
         return self.data_from_svo(query=query, error_msg=error_msg, **kwargs)
 
-    def get_filter_list(self, facility, instrument=None, **kwargs):
+    def get_filter_list(self, facility, *, instrument=None, **kwargs):
         """Get filters data for requested facilty and instrument from SVO
 
         Parameters

astroquery/svo_fps/tests/test_svo_fps.py

@@ -79,7 +79,7 @@ def test_get_transmission_data(patch_get):
 
 
 def test_get_filter_list(patch_get):
-    table = SvoFps.get_filter_list(TEST_FACILITY, TEST_INSTRUMENT)
+    table = SvoFps.get_filter_list(TEST_FACILITY, instrument=TEST_INSTRUMENT)
     # Check if column for Filter ID (named 'filterID') exists in table
     assert 'filterID' in table.colnames
 

astroquery/svo_fps/tests/test_svo_fps_remote.py

@@ -26,7 +26,7 @@ def test_get_transmission_data(self, test_filter_id):
     @pytest.mark.parametrize('test_facility, test_instrument',
                              [('HST', 'WFPC2'), ('Keck', None)])
     def test_get_filter_list(self, test_facility, test_instrument):
-        table = SvoFps.get_filter_list(test_facility, test_instrument)
+        table = SvoFps.get_filter_list(test_facility, instrument=test_instrument)
         # Check if column for Filter ID (named 'filterID') exists in table
         assert 'filterID' in table.colnames