maint: remove list_fields_async

everything done with list_fields

Author: ManonMarchand

astroquery/mocserver/core.py

@@ -421,7 +421,7 @@ def query_async(
             return request_payload
         return self._request(**params_d)
 
-    def list_fields(self, keyword=None, cache=True):
+    def list_fields(self, keyword=None, *, cache=True):
         """List MOC Server fields.
 
         In the MOC Server, the fields are free. This means that anyone publishing there
@@ -458,7 +458,9 @@ def list_fields(self, keyword=None, cache=True):
         hips_publisher         14                       CDS
 
         """
-        fields_descriptions = dict(self.list_fields_async(cache=cache).json()[0])
+        fields_descriptions = dict(
+            self._request(method="GET", url=self.URL, timeout=self.TIMEOUT, cache=cache,
+                          params={"get": "example", "fmt": "json"}).json()[0])
         occurrences = [
             int(value.split("x")[0][1:]) for value in fields_descriptions.values()
         ]
@@ -478,37 +480,6 @@ def list_fields(self, keyword=None, cache=True):
             ]
         return list_fields
 
-    def list_fields_async(self, cache=True):
-        """List MOC Server fields asynchronously.
-
-        In the MOC Server, the fields are free. This means that anyone publishing there
-        can set a new field. This results in a long set of possible fields, that are
-        more or less frequent in the database.
-        This method allows to retrieve all fields currently existing, with their
-        occurrences and an example.
-
-        Parameters
-        ----------
-        keyword : str, optional
-            A keyword to filter the output for fields that have the keyword in their
-            name. This is not case-sensitive.
-            If you don't give a keyword, you will retrieve all existing fields.
-        cache: bool, optional
-            Whether the response should be cached.
-
-        Returns
-        -------
-        `~requests.models.Response`
-
-        """
-        return self._request(
-            method="GET",
-            url=self.URL,
-            timeout=self.TIMEOUT,
-            cache=cache,
-            params={"get": "example", "fmt": "json"},
-        )
-
     def list_coordinate_systems(self):
         """Return the list of coordinate systems currently available in the MOC Server.
 

astroquery/mocserver/tests/test_mocserver.py

@@ -3,6 +3,7 @@
 from pathlib import Path
 
 import pytest
+import requests
 
 from astropy import coordinates
 from astropy.io.votable import parse_single_table
@@ -107,25 +108,24 @@ def _mock_list_fields(monkeypatch):
     # This response changes with time. To regenerate it, do:
     # >>> from astroquery.mocserver import MOCServer
     # >>> import json
-    # >>> response = MOCServer.list_fields_async()
+    # >>> response = MOCServer._request(method="GET", url=self.URL,
+    # ...                               timeout=self.TIMEOUT, cache=cache,
+    # ...                               params={"get": "example", "fmt": "json"}).json()[0]
     # >>> with open("list_fields.json", "w") as f:
     # ...     json.dump(dict(response.json()[0]))
     class MockedListFields:
         def json(self):
             with open(Path(__file__).parent / "data" / "list_fields.json", "r") as f:
                 return [json.load(f)]
 
-    monkeypatch.setattr(
-        mocserver.MOCServerClass,
-        "list_fields_async",
-        lambda self, cache: MockedListFields(),
-    )
+    monkeypatch.setattr(requests.Session, 'send',
+                        lambda *args, **kwargs: MockedListFields())
 
 
 @pytest.mark.skipif(not HAS_MOCPY, reason="mocpy is required")
 @pytest.mark.usefixtures("_mock_list_fields")
 def test_list_fields():
-    fields = MOCServer.list_fields("id")
+    fields = MOCServer.list_fields("id", cache=False)
     assert "ID" in fields["field_name"]