Skip to content

Commit 19ff5bb

Browse files
committed
Using single line kwargs.get() instead of if/else
1 parent 49f2c18 commit 19ff5bb

File tree

4 files changed

+10
-17
lines changed

4 files changed

+10
-17
lines changed

astroquery/nrao/core.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,8 @@ def _args_to_payload(self, **kwargs):
172172
EQUINOX=kwargs.get('equinox', 'J2000'),
173173
CENTER_RA='',
174174
CENTER_DEC='',
175-
SRAD=str(commons.parse_radius(kwargs['radius']).degree) + 'd' if 'radius' in kwargs else "1.0'",
175+
SRAD=str(
176+
commons.parse_radius(kwargs.get('radius', "1.0m")).deg) + 'd',
176177
TELESCOPE_CONFIG=kwargs.get('telescope_config', 'all').upper(),
177178
OBS_BANDS=kwargs.get('obs_band', 'all').upper(),
178179
SUBARRAY=kwargs.get('subarray', 'all').upper(),
@@ -258,12 +259,13 @@ def _parse_result(self, response, verbose=False):
258259
'name="Telescope:config" '
259260
' arraysize="*" ', new_content)
260261

261-
datatype_mapping = {'integer':'long'}
262+
datatype_mapping = {'integer': 'long'}
262263

263264
try:
264265
tf = six.BytesIO(new_content.encode())
265-
first_table = votable.parse(tf, pedantic=False,
266-
datatype_mapping=datatype_mapping).get_first_table()
266+
first_table = votable.parse(
267+
tf, pedantic=False,
268+
datatype_mapping=datatype_mapping).get_first_table()
267269
try:
268270
table = first_table.to_table(use_names_over_ids=True)
269271
except TypeError:

astroquery/nrao/tests/test_nrao.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ def parse_coordinates_mock_return(c):
2828
return mp
2929

3030

31-
3231
@pytest.fixture
3332
def patch_post(request):
3433
mp = request.getfuncargvalue("monkeypatch")

astroquery/ukidss/core.py

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -132,15 +132,9 @@ def logged_in(self):
132132
def _args_to_payload(self, *args, **kwargs):
133133
request_payload = {}
134134

135-
if 'database' in kwargs:
136-
request_payload['database'] = kwargs['database']
137-
else:
138-
request_payload['database'] = self.database
135+
request_payload['database'] = kwargs.get('database', self.database)
139136

140-
if 'programme_id' in kwargs:
141-
programme_id = kwargs['programme_id']
142-
else:
143-
programme_id = self.programme_id
137+
programme_id = kwargs.get('programme_id', self.programme_id)
144138

145139
request_payload['programmeID'] = verify_programme_id(
146140
programme_id, query_type=kwargs['query_type'])

astroquery/utils/process_asyncs.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,8 @@ def create_method(async_method_name):
2121

2222
@class_or_instance
2323
def newmethod(self, *args, **kwargs):
24-
if 'verbose' in kwargs:
25-
verbose = kwargs.pop('verbose')
26-
else:
27-
verbose = False
24+
verbose = kwargs.pop('verbose', False)
25+
2826
response = getattr(self, async_method_name)(*args, **kwargs)
2927
if kwargs.get('get_query_payload') or kwargs.get('field_help'):
3028
return response

0 commit comments

Comments
 (0)