Skip to content

Commit 1b241d5

Browse files
authored
Merge pull request #2215 from keflavich/fix_atomic_tests_by_not_caching
Fix for remote tests: atomic
2 parents a654433 + c30a543 commit 1b241d5

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

astroquery/atomic/core.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ def query_object_async(self, wavelength_range=None, wavelength_type='', waveleng
246246
return response
247247

248248
def _parse_result(self, response):
249-
data = StringIO(BeautifulSoup(response.text).find('pre').text.strip())
249+
data = StringIO(BeautifulSoup(response.text, 'html5').find('pre').text.strip())
250250
# `header` is e.g.:
251251
# "u'-LAMBDA-VAC-ANG-|-SPECTRUM--|TT|--------TERM---------|---J-J---|----LEVEL-ENERGY--CM-1----'"
252252
# `colnames` is then
@@ -306,7 +306,7 @@ def _default_form_values(self):
306306
if self.__default_form_values is None:
307307
response = self._request("GET", url=self.FORM_URL, data={},
308308
timeout=self.TIMEOUT, cache=True)
309-
bs = BeautifulSoup(response.text)
309+
bs = BeautifulSoup(response.text, 'html5')
310310
self._default_form = form = bs.find('form')
311311
self.__default_form_values = self._get_default_form_values(form)
312312

astroquery/atomic/tests/test_atomic_remote.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ def test_default_form_values():
1212
default_response = AtomicLineList._request(
1313
method="GET", url=AtomicLineList.FORM_URL,
1414
data={}, timeout=AtomicLineList.TIMEOUT)
15-
bs = BeautifulSoup(default_response.text)
15+
bs = BeautifulSoup(default_response.text, 'html5')
1616
form = bs.find('form')
1717

1818
default_form_values = AtomicLineList._get_default_form_values(form)
@@ -30,7 +30,7 @@ def test_default_form_values():
3030

3131
@pytest.mark.remote_data
3232
def test_query_with_default_params():
33-
table = AtomicLineList.query_object()
33+
table = AtomicLineList.query_object(cache=False)
3434
assert isinstance(table, Table)
3535
assert len(table) == 500
3636
assert str(table[:5]) == '''
@@ -49,7 +49,8 @@ def test_query_with_wavelength_params():
4949
wavelength_range=(15 * u.nm, 200 * u.Angstrom),
5050
wavelength_type='Air',
5151
wavelength_accuracy=20,
52-
element_spectrum='C II-IV')
52+
element_spectrum='C II-IV',
53+
cache=False)
5354
assert isinstance(result, Table)
5455
assert result.colnames == ['LAMBDA VAC ANG', 'SPECTRUM', 'TT',
5556
'CONFIGURATION', 'TERM', 'J J', 'A_ki',
@@ -67,7 +68,7 @@ def test_query_with_wavelength_params():
6768

6869
@pytest.mark.remote_data
6970
def test_empty_result_set():
70-
result = AtomicLineList.query_object(wavelength_accuracy=0)
71+
result = AtomicLineList.query_object(wavelength_accuracy=0, cache=False)
7172
assert isinstance(result, Table)
7273
assert not result
7374
assert len(result) == 0
@@ -78,7 +79,7 @@ def test_lower_upper_ranges():
7879
result = AtomicLineList.query_object(
7980
lower_level_energy_range=u.Quantity((600 * u.cm**(-1), 1000 * u.cm**(-1))),
8081
upper_level_energy_range=u.Quantity((15000 * u.cm**(-1), 100000 * u.cm**(-1))),
81-
element_spectrum='Ne III')
82+
element_spectrum='Ne III', cache=False)
8283
assert isinstance(result, Table)
8384

8485
assert np.all(result['LAMBDA VAC ANG'] ==

0 commit comments

Comments
 (0)