BUG: ignore column int overflow warning for windows

Author: bsipocz

astroquery/sdss/core.py

@@ -4,10 +4,12 @@
 """
 import warnings
 import numpy as np
+import sys
 
 from astropy import units as u
 from astropy.coordinates import Angle
 from astropy.table import Table, Column
+from astropy.utils.exceptions import AstropyWarning
 
 from ..query import BaseQuery
 from . import conf
@@ -935,7 +937,16 @@ def _parse_result(self, response, verbose=False):
         if 'error_message' in response.text:
             raise RemoteServiceError(response.text)
 
-        arr = Table.read(response.text, format='ascii.csv', comment="#")
+        with warnings.catch_warnings():
+            # Capturing the warning and converting the objid column to int64 is necessary for consistency as
+            # it was convereted to string on systems with defaul integer int32 due to an overflow.
+            if sys.platform.startswith('win'):
+                warnings.filterwarnings("ignore", category=AstropyWarning,
+                                        message=r'OverflowError converting to IntType in column.*')
+            arr = Table.read(response.text, format='ascii.csv', comment="#")
+            for id_column in ['objid', 'specobjid']:
+                if id_column in arr.columns:
+                    arr[id_column] = arr[id_column].astype(np.int64)
 
         if len(arr) == 0:
             return None

astroquery/sdss/tests/test_sdss.py

@@ -5,11 +5,14 @@
 import socket
 import numpy as np
 from numpy.testing import assert_allclose
+import sys
+import warnings
 
 import astropy.units as u
 from astropy.io import fits
 from astropy.coordinates import Angle
 from astropy.table import Column, Table
+from astropy.utils.exceptions import AstropyWarning
 import pytest
 
 from ... import sdss
@@ -194,11 +197,17 @@ class = 'galaxy'
               and zWarning = 0
             """
     xid = sdss.SDSS.query_sql(query, data_release=dr)
-    data = Table.read(data_path(DATA_FILES['images_id']),
-                      format='ascii.csv', comment='#')
 
-    compare_xid_data(xid, data)
-    url_tester(dr)
+    with warnings.catch_warnings():
+        if sys.platform.startswith('win'):
+            warnings.filterwarnings("ignore", category=AstropyWarning,
+                                    message=r'OverflowError converting.*')
+        data = Table.read(data_path(DATA_FILES['images_id']),
+                          format='ascii.csv', comment='#')
+
+        data['objid'] = data['objid'].astype(np.int64)
+        compare_xid_data(xid, data)
+        url_tester(dr)
 
 
 @pytest.mark.parametrize("dr", dr_list)
@@ -232,39 +241,68 @@ def test_sdss_template(patch_request, patch_get_readable_fileobj):
 @pytest.mark.parametrize("dr", dr_list)
 def test_sdss_specobj(patch_request, dr):
     xid = sdss.SDSS.query_specobj(plate=2340, data_release=dr)
-    data = Table.read(data_path(DATA_FILES['spectra_id']),
-                      format='ascii.csv', comment='#')
 
-    compare_xid_data(xid, data)
-    url_tester(dr)
+    with warnings.catch_warnings():
+        if sys.platform.startswith('win'):
+            warnings.filterwarnings("ignore", category=AstropyWarning,
+                                    message=r'OverflowError converting.*')
+        data = Table.read(data_path(DATA_FILES['spectra_id']),
+                          format='ascii.csv', comment='#')
+        data['objid'] = data['objid'].astype(np.int64)
+        data['specobjid'] = data['specobjid'].astype(np.int64)
+        compare_xid_data(xid, data)
+        url_tester(dr)
 
 
 @pytest.mark.parametrize("dr", dr_list)
 def test_sdss_photoobj(patch_request, dr):
     xid = sdss.SDSS.query_photoobj(
         run=1904, camcol=3, field=164, data_release=dr)
-    data = Table.read(data_path(DATA_FILES['images_id']),
-                      format='ascii.csv', comment='#')
-    compare_xid_data(xid, data)
-    url_tester(dr)
+
+    with warnings.catch_warnings():
+        if sys.platform.startswith('win'):
+            warnings.filterwarnings("ignore", category=AstropyWarning,
+                                    message=r'OverflowError converting.*')
+        data = Table.read(data_path(DATA_FILES['images_id']),
+                          format='ascii.csv', comment='#')
+
+        data['objid'] = data['objid'].astype(np.int64)
+        compare_xid_data(xid, data)
+        url_tester(dr)
 
 
 @pytest.mark.parametrize("dr", dr_list)
 def test_list_coordinates(patch_request, dr):
     xid = sdss.SDSS.query_region(coords_list, data_release=dr)
-    data = Table.read(data_path(DATA_FILES['images_id']),
-                      format='ascii.csv', comment='#')
-    compare_xid_data(xid, data)
-    url_tester_crossid(dr)
+
+    with warnings.catch_warnings():
+        if sys.platform.startswith('win'):
+            warnings.filterwarnings("ignore", category=AstropyWarning,
+                                    message=r'OverflowError converting.*')
+        data = Table.read(data_path(DATA_FILES['images_id']),
+                          format='ascii.csv', comment='#')
+
+        data['objid'] = data['objid'].astype(np.int64)
+
+        compare_xid_data(xid, data)
+        url_tester_crossid(dr)
 
 
 @pytest.mark.parametrize("dr", dr_list)
 def test_column_coordinates(patch_request, dr):
     xid = sdss.SDSS.query_region(coords_column, data_release=dr)
-    data = Table.read(data_path(DATA_FILES['images_id']),
-                      format='ascii.csv', comment='#')
-    compare_xid_data(xid, data)
-    url_tester_crossid(dr)
+
+    with warnings.catch_warnings():
+        if sys.platform.startswith('win'):
+            warnings.filterwarnings("ignore", category=AstropyWarning,
+                                    message=r'OverflowError converting.*')
+        data = Table.read(data_path(DATA_FILES['images_id']),
+                          format='ascii.csv', comment='#')
+
+        data['objid'] = data['objid'].astype(np.int64)
+
+        compare_xid_data(xid, data)
+        url_tester_crossid(dr)
 
 
 def test_query_timeout(patch_request_slow, coord=coords):
@@ -285,10 +323,18 @@ def test_images_timeout(patch_request, patch_get_readable_fileobj_slow):
 @pytest.mark.parametrize("dr", dr_list)
 def test_query_crossid(patch_request, dr):
     xid = sdss.SDSS.query_crossid(coords_column, data_release=dr)
-    data = Table.read(data_path(DATA_FILES['images_id']),
-                      format='ascii.csv', comment='#')
-    compare_xid_data(xid, data)
-    url_tester_crossid(dr)
+
+    with warnings.catch_warnings():
+        if sys.platform.startswith('win'):
+            warnings.filterwarnings("ignore", category=AstropyWarning,
+                                    message=r'OverflowError converting.*')
+        data = Table.read(data_path(DATA_FILES['images_id']),
+                          format='ascii.csv', comment='#')
+
+        data['objid'] = data['objid'].astype(np.int64)
+
+        compare_xid_data(xid, data)
+        url_tester_crossid(dr)
 
 
 def test_query_crossid_large_radius(patch_request):