Skip to content

Commit 2d1a330

Browse files
rickynilssonbsipocz
rickynilsson
authored and
bsipocz
committed
Create separate mock for planet.
1 parent 336840b commit 2d1a330

File tree

2 files changed

+128
-7
lines changed

2 files changed

+128
-7
lines changed

‎astroquery/ipac/nexsci/nasa_exoplanet_archive/tests/data/bpicb_aliaslookup.json

Lines changed: 105 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,105 @@
1+
{
2+
"manifest": {
3+
"requested_name": "bet pic b",
4+
"resolved_name": "bet Pic b",
5+
"system_name": "bet Pic",
6+
"lookup_status": "OK",
7+
"compilation_date": "2022-07-13 16:53:58.899538",
8+
"system_snapshot": {
9+
"number_of_stars": 1,
10+
"number_of_planets": 2
11+
}
12+
},
13+
"system": {
14+
"system_info": {
15+
"id": "bet Pic",
16+
"alias_set": {
17+
"item_count": 1,
18+
"default_name": "bet Pic",
19+
"aliases": [
20+
"bet Pic"
21+
]
22+
}
23+
},
24+
"objects": {
25+
"stellar_set": {
26+
"item_count": 1,
27+
"stars": {
28+
"bet Pic": {
29+
"is_host": "True",
30+
"alias_set": {
31+
"item_count": 14,
32+
"default_name": "bet Pic",
33+
"aliases": [
34+
"TIC 270577175",
35+
"Gaia DR2 4792774797545105664",
36+
"GJ 219",
37+
"HR 2020",
38+
"bet Pic",
39+
"HD 39060",
40+
"HIP 27321",
41+
"SAO 234134",
42+
"CD-51 1620",
43+
"CPD-51 774",
44+
"IRAS 05460-5104",
45+
"TYC 8099-01392-1",
46+
"2MASS J05471708-5103594",
47+
"WISE J054717.10-510358.4"
48+
]
49+
}
50+
}
51+
}
52+
},
53+
"planet_set": {
54+
"item_count": 2,
55+
"planets": {
56+
"bet Pic b": {
57+
"requested_object": "True",
58+
"alias_set": {
59+
"item_count": 14,
60+
"default_name": "bet Pic b",
61+
"aliases": [
62+
"GJ 219 b",
63+
"HR 2020 b",
64+
"bet Pic b",
65+
"HD 39060 b",
66+
"HIP 27321 b",
67+
"SAO 234134 b",
68+
"CD-51 1620 b",
69+
"CPD-51 774 b",
70+
"IRAS 05460-5104 b",
71+
"TYC 8099-01392-1 b",
72+
"2MASS J05471708-5103594 b",
73+
"WISE J054717.10-510358.4 b",
74+
"TIC 270577175 b",
75+
"Gaia DR2 4792774797545105664 b"
76+
]
77+
}
78+
},
79+
"bet Pic c": {
80+
"alias_set": {
81+
"item_count": 14,
82+
"default_name": "bet Pic c",
83+
"aliases": [
84+
"GJ 219 c",
85+
"HR 2020 c",
86+
"bet Pic c",
87+
"HD 39060 c",
88+
"HIP 27321 c",
89+
"SAO 234134 c",
90+
"CD-51 1620 c",
91+
"CPD-51 774 c",
92+
"IRAS 05460-5104 c",
93+
"TYC 8099-1392-1 c",
94+
"2MASS J05471708-5103594 c",
95+
"WISE J054717.10-510358.4 c",
96+
"TIC 270577175 c",
97+
"Gaia DR2 4792774797545105664 c"
98+
]
99+
}
100+
}
101+
}
102+
}
103+
}
104+
}
105+
}

‎astroquery/ipac/nexsci/nasa_exoplanet_archive/tests/test_nasa_exoplanet_archive.py

Lines changed: 23 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ def patch_get(request): # pragma: nocover
120120

121121

122122
# aliaslookup file in data/
123-
LOOKUP_DATA_FILE = 'bpic_aliaslookup.json'
123+
LOOKUP_DATA_FILE = ['bpic_aliaslookup.json', 'bpicb_aliaslookup.json']
124124

125125

126126
def data_path(filename):
@@ -129,22 +129,38 @@ def data_path(filename):
129129

130130

131131
# monkeypatch replacement request function
132-
def query_aliases_mock(self, *args, **kwargs):
133-
with open(data_path(LOOKUP_DATA_FILE), 'rb') as f:
132+
def query_aliases_mock_0(self, *args, **kwargs):
133+
with open(data_path(LOOKUP_DATA_FILE[0]), 'rb') as f:
134134
response = json.load(f)
135135
return response
136136

137137

138138
# use a pytest fixture to create a dummy 'requests.get' function,
139139
# that mocks(monkeypatches) the actual 'requests.get' function:
140140
@pytest.fixture
141-
def query_aliases_request(request):
141+
def query_aliases_request_0(request):
142142
mp = request.getfixturevalue("monkeypatch")
143-
mp.setattr(NasaExoplanetArchiveClass, '_request_query_aliases', query_aliases_mock)
143+
mp.setattr(NasaExoplanetArchiveClass, '_request_query_aliases', query_aliases_mock_0)
144144
return mp
145145

146146

147-
def test_query_aliases(query_aliases_request):
147+
# monkeypatch replacement request function
148+
def query_aliases_mock_1(self, *args, **kwargs):
149+
with open(data_path(LOOKUP_DATA_FILE[1]), 'rb') as f:
150+
response = json.load(f)
151+
return response
152+
153+
154+
# use a pytest fixture to create a dummy 'requests.get' function,
155+
# that mocks(monkeypatches) the actual 'requests.get' function:
156+
@pytest.fixture
157+
def query_aliases_request_1(request):
158+
mp = request.getfixturevalue("monkeypatch")
159+
mp.setattr(NasaExoplanetArchiveClass, '_request_query_aliases', query_aliases_mock_1)
160+
return mp
161+
162+
163+
def test_query_aliases(query_aliases_request_0):
148164
nasa_exoplanet_archive = NasaExoplanetArchiveClass()
149165
result = nasa_exoplanet_archive.query_aliases(object_name='bet Pic')
150166
assert len(result) > 10
@@ -153,7 +169,7 @@ def test_query_aliases(query_aliases_request):
153169
assert '2MASS J05471708-5103594' in result
154170

155171

156-
def test_query_aliases_planet(query_aliases_request):
172+
def test_query_aliases_planet(query_aliases_request_1):
157173
nasa_exoplanet_archive = NasaExoplanetArchiveClass()
158174
result = nasa_exoplanet_archive.query_aliases('bet Pic b')
159175
assert len(result) > 10

0 commit comments

Comments
 (0)