Addressing review

Author: bsipocz

astroquery/ipac/irsa/core.py

@@ -128,8 +128,7 @@ def query_sia(self, *, pos=None, band=None, time=None, pol=None,
 
     query_sia.__doc__ = query_sia.__doc__.replace('_SIA2_PARAMETERS', SIA2_PARAMETERS_DESC)
 
-    def query_ssa(self, *, pos=None, diameter=None, band=None, time=None, format=None,
-                  collection=None):
+    def query_ssa(self, *, pos=None, radius=None, band=None, time=None, collection=None):
         """
         Use standard SSA attributes to query the IRSA SSA service.
 
@@ -138,8 +137,8 @@ def query_ssa(self, *, pos=None, diameter=None, band=None, time=None, format=Non
         pos : `~astropy.coordinates.SkyCoord` class or sequence of two floats
             the position of the center of the circular search region.
             assuming icrs decimal degrees if unit is not specified.
-        diameter : `~astropy.units.Quantity` class or scalar float
-            the diameter of the circular region around pos in which to search.
+        raidus : `~astropy.units.Quantity` class or scalar float
+            the radius of the circular region around pos in which to search.
             assuming icrs decimal degrees if unit is not specified.
         band : `~astropy.units.Quantity` class or sequence of two floats
             the bandwidth range the observations belong to.
@@ -149,20 +148,20 @@ def query_ssa(self, *, pos=None, diameter=None, band=None, time=None, format=Non
             assuming iso 8601 if format is not specified.
         collection : str
            Name of the collection that the data belongs to.
-        format : str
-           the image format(s) of interest.  "all" indicates
-           all available formats; "graphic" indicates
-           graphical images (e.g. jpeg, png, gif; not FITS);
-           "metadata" indicates that no images should be
-           returned--only an empty table with complete metadata.
 
         Returns
         -------
         Results in `pyvo.dal.SSAResults` format.
-        result.table in Astropy table format
+        result.to_table() in Astropy table format
         """
+
+        if radius is None:
+            diameter = None
+        else:
+            diameter = 2 * radius
+            
         return self.ssa.search(pos=pos, diameter=diameter, band=band, time=time,
-                               format=format, collection=collection)
+                               format='all', collection=collection)
 
     def list_collections(self, servicetype=None):
         """

astroquery/ipac/irsa/tests/test_irsa_remote.py

@@ -92,5 +92,5 @@ def test_ssa(self):
         coord = SkyCoord.from_name("Eta Carina")
         result = Irsa.query_ssa(pos=coord)
         assert len(result) > 260
-        collections = set(unique(result.to_table(), keys='dataid_collection')['dataid_collection'])
+        collections = set(result.to_table()['dataid_collection'])
         assert {'champ', 'iso_sws', 'sofia_forcast', 'sofia_great', 'spitzer_sha'}.issubset(collections)

docs/ipac/irsa/irsa.rst

@@ -334,7 +334,7 @@ Enhanced Imaging products in the centre of the COSMOS field as an `~astropy.tabl
    >>> arp220_spectra = Irsa.query_ssa(pos=coord).to_table()
 
 Without specifying the collection, the query returns results from multiple
-collections. For example this target has spectra from Sofia as well as from
+collections. For example this target has spectra from SOFIA as well as from
 Spitzer.
 
 .. doctest-remote-data::