Skip to content

Commit 2f73f46

Browse files
committed
MAINT: xfail problematic asteroid names
1 parent 568ff61 commit 2f73f46

File tree

1 file changed

+14
-12
lines changed

1 file changed

+14
-12
lines changed

astroquery/mpc/tests/test_mpc_remote.py

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -9,31 +9,33 @@
99
@pytest.mark.remote_data
1010
class TestMPC:
1111

12-
@pytest.mark.parametrize('type, name', [
12+
@pytest.mark.parametrize('target_type, name', [
1313
('asteroid', 'ceres'),
1414
('asteroid', 'eros'),
15-
('asteroid', 'vesta')])
16-
def test_query_object_valid_object_by_name(self, type, name):
17-
response = mpc.MPC.query_object_async(target_type=type, name=name)
15+
('asteroid', 'vesta'),
16+
('asteroid', 'pallas'),
17+
('asteroid', 'piszkesteto')])
18+
def test_query_object_valid_object_by_name(self, target_type, name):
19+
# Keep all 3 of the objects in the tests, too that used to cause issue
20+
# https://github.com/astropy/astroquery/issues/2531
21+
response = mpc.MPC.query_object_async(target_type=target_type, name=name)
1822
assert response.status_code == requests.codes.ok
1923
assert len(response.json()) == 1
2024
assert response.json()[0]['name'].lower() == name
2125

22-
@pytest.mark.parametrize('type, number', [
26+
@pytest.mark.parametrize('target_type, number', [
2327
('comet', '103P')])
24-
def test_query_object_valid_object_by_number(self, type, number):
25-
response = mpc.MPC.query_object_async(
26-
target_type=type, number=number)
28+
def test_query_object_valid_object_by_number(self, target_type, number):
29+
response = mpc.MPC.query_object_async(target_type=target_type, number=number)
2730
assert response.status_code == requests.codes.ok
2831
assert len(response.json()) == 1
2932
assert str(response.json()[0]['number']) + \
3033
response.json()[0]['object_type'] == number
3134

32-
@pytest.mark.parametrize('type, designation', [
35+
@pytest.mark.parametrize('target_type, designation', [
3336
('comet', 'C/2012 S1')])
34-
def test_query_object_valid_object_by_designation(self, type, designation):
35-
response = mpc.MPC.query_object_async(
36-
target_type=type, designation=designation)
37+
def test_query_object_valid_object_by_designation(self, target_type, designation):
38+
response = mpc.MPC.query_object_async(target_type=target_type, designation=designation)
3739
assert response.status_code == requests.codes.ok
3840
assert len(response.json()) == 1
3941
assert response.json()[0]['designation'].lower() == designation.lower()

0 commit comments

Comments
 (0)