Skip to content

Commit 2fb04f1

Browse files
committed
fixed for cases where just a tuple is fed to sort_by
1 parent ffb14a7 commit 2fb04f1

File tree

1 file changed

+7
-11
lines changed

1 file changed

+7
-11
lines changed

astroquery/mast/services.py

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -285,6 +285,10 @@ def service_request_async(self, service, params, page_size=None, page=None, use_
285285
# was specified
286286
if 'sort_by' in params.keys():
287287
new_sort_by = []
288+
289+
# If just a tuple is fed, turn it into a list with a single tuple element
290+
if not isinstance(params['sort_by'], list):
291+
params['sort_by'] = [(params['sort_by'][0], params['sort_by'][1])]
288292
for item in params['sort_by']:
289293
if item[0].lower() in ['asc', 'desc']:
290294
new_sort_by.append(item[1] + '.' + item[0])
@@ -324,17 +328,9 @@ def _build_catalogs_params(self, params):
324328
elif prop == 'page_size':
325329
catalog_params.extend(('pagesize', value))
326330
elif prop == 'sort_by':
327-
# Loop through each value if list
328-
if isinstance(value, list):
329-
for sort_item in value:
330-
catalog_params.append(('sort_by', sort_item))
331-
else:
332-
# A single sort
333-
# Determine if tuple with sort direction
334-
if isinstance(value, tuple):
335-
catalog_params.append(('sort_by', value[0] + '.' + value[1]))
336-
else:
337-
catalog_params.append(('sort_by', value))
331+
# Loop through each value
332+
for sort_item in value:
333+
catalog_params.append(('sort_by', sort_item))
338334
elif prop == 'columns':
339335
catalog_params.extend(tuple(('columns', col) for col in value))
340336
else:

0 commit comments

Comments
 (0)