Merge pull request #2654 from bsipocz/MAINT_https_for_sdss

FIX: switching to https for sdss to avoid query issues

Author: bsipocz

CHANGES.rst

@@ -151,6 +151,12 @@ oac
 - Fix bug in parsing events that contain html tags (e.g. in their alias
   field). [#2423]
 
+sdss
+^^^^
+
+- Switching to https to avoid issues originating in relying on server side
+  redirects. [#2654]
+
 simbad
 ^^^^^^
 

astroquery/sdss/__init__.py

@@ -11,7 +11,7 @@ class Conf(_config.ConfigNamespace):
     Configuration parameters for `astroquery.sdss`.
     """
     skyserver_baseurl = _config.ConfigItem(
-        'http://skyserver.sdss.org',
+        'https://skyserver.sdss.org',
         'Base URL for catalog-related queries like SQL and Cross-ID.')
     sas_baseurl = _config.ConfigItem(
         'https://data.sdss.org/sas',

astroquery/sdss/tests/test_sdss.py

@@ -123,25 +123,25 @@ def data_path(filename):
 # interfaces are supported for DR11."
 def url_tester(data_release):
     if data_release < 10:
-        baseurl = 'http://skyserver.sdss.org/dr{}/en/tools/search/x_sql.asp'
+        baseurl = 'https://skyserver.sdss.org/dr{}/en/tools/search/x_sql.asp'
     if data_release == 10:
-        baseurl = 'http://skyserver.sdss.org/dr{}/en/tools/search/x_sql.aspx'
+        baseurl = 'https://skyserver.sdss.org/dr{}/en/tools/search/x_sql.aspx'
     if data_release == 11:
         return
     if data_release >= 12:
-        baseurl = 'http://skyserver.sdss.org/dr{}/en/tools/search/x_results.aspx'
+        baseurl = 'https://skyserver.sdss.org/dr{}/en/tools/search/x_results.aspx'
     assert sdss.SDSS._last_url == baseurl.format(data_release)
 
 
 def url_tester_crossid(data_release):
     if data_release < 10:
-        baseurl = 'http://skyserver.sdss.org/dr{}/en/tools/crossid/x_crossid.asp'
+        baseurl = 'https://skyserver.sdss.org/dr{}/en/tools/crossid/x_crossid.asp'
     if data_release == 10:
-        baseurl = 'http://skyserver.sdss.org/dr{}/en/tools/crossid/x_crossid.aspx'
+        baseurl = 'https://skyserver.sdss.org/dr{}/en/tools/crossid/x_crossid.aspx'
     if data_release == 11:
         return
     if data_release >= 12:
-        baseurl = 'http://skyserver.sdss.org/dr{}/en/tools/search/X_Results.aspx'
+        baseurl = 'https://skyserver.sdss.org/dr{}/en/tools/search/X_Results.aspx'
     assert sdss.SDSS._last_url == baseurl.format(data_release)