Updated comments part with the changes proposed

Author: mhsarmiento

astroquery/gaia/core.py

@@ -903,20 +903,23 @@ def launch_job_async(self, query, name=None, output_file=None,
 
     def rename_table(self, table_name=None, new_table_name=None, new_column_names_dict={},
                      verbose=False):
-        """
-            This new method allows to update the column names of a user table.
-            header example: rename_table(table_name=old_table_name, new_table_name=new_table_name -optional-
-             , new_column_names_dict=[old_column1:new_column1, old_column2:new_colum2...])
-            Parameters
-            ----------
-            table_name: str, required
-                old name of the user's table
-            new_table_name: str, required
-                new name of the user's table
-            new_column_names_dict: dict str:str, required
-                dict with pairs "old_column1_name:new_column1_name"
-            verbose : bool, optional, default 'False'
-                flag to display information about the process
+        """ This new method allows you to update the column names of a user table.
+
+        Parameters
+        ----------
+        table_name: str, required
+            old name of the user's table
+        new_table_name: str, required
+            new name of the user's table
+        new_column_names_dict: dict str:str, required
+            dict with pairs "old_column1_name:new_column1_name"
+        verbose : bool, optional, default 'False'
+            flag to display information about the process
+
+        Example
+        -------
+        TapPlus.rename_table.rename_table(table_name=old_table_name, new_table_name=new_table_name,
+        new_column_names_dict=[old_column1:new_column1, old_column2:new_column2, ...])
         """
         return TapPlus.rename_table(self, table_name=table_name, new_table_name=new_table_name,
                                     new_column_names_dict=new_column_names_dict, verbose=verbose)

astroquery/utils/tap/conn/tapconn.py

@@ -87,7 +87,7 @@ def __init__(self, ishttps,
         self.__connPort = port
         self.__connPortSsl = sslport
         if server_context is not None:
-            if(server_context.startswith("/")):
+            if (server_context.startswith("/")):
                 self.__serverContext = server_context
             else:
                 self.__serverContext = f"/{server_context}"
@@ -107,7 +107,7 @@ def __init__(self, ishttps,
 
     def __create_context(self, context):
         if (context is not None and context != ""):
-            if(str(context).startswith("/")):
+            if (str(context).startswith("/")):
                 return f"{self.__serverContext}{context}"
             else:
                 return f"{self.__serverContext}/{context}"
@@ -125,7 +125,7 @@ def __interna_init(self):
         self.__postHeaders = {
             "Content-type": CONTENT_TYPE_POST_DEFAULT,
             "Accept": "text/plain"
-            }
+        }
         self.__getHeaders = {}
         self.__cookie = None
         self.__currentStatus = 0
@@ -414,9 +414,6 @@ def execute_table_tool(self, data,
         context = self.__get_table_edit_context()
         return self.__execute_post(context, data, content_type, verbose)
 
-
-
-
     def __execute_post(self, context, data,
                        content_type=CONTENT_TYPE_POST_DEFAULT,
                        verbose=False):
@@ -602,7 +599,7 @@ def get_file_from_header(self, headers):
         if content_disposition is not None:
             p = content_disposition.find('filename="')
             if p >= 0:
-                filename = content_disposition[p+10:len(content_disposition)-1]
+                filename = content_disposition[p + 10:len(content_disposition) - 1]
                 content_encoding = self.find_header(headers, 'Content-Encoding')
                 if content_encoding is not None:
                     if "gzip" == content_encoding.lower():
@@ -736,7 +733,7 @@ def encode_multipart(self, fields, files):
 
     def __str__(self):
         return f"\tHost: {self.__connHost}\n\tUse HTTPS: {self.__isHttps}" \
-            f"\n\tPort: {self.__connPort}\n\tSSL Port: {self.__connPortSsl}"
+               f"\n\tPort: {self.__connPort}\n\tSSL Port: {self.__connPortSsl}"
 
 
 class ConnectionHandler:

astroquery/utils/tap/core.py

@@ -13,8 +13,6 @@
 Created on 30 jun. 2016
 Modified on 1 jun. 2021 by mhsarmiento
 Version: gaia-astroquery-1.0
-
-
 """
 from astroquery.utils.tap import taputils
 from astroquery.utils.tap.conn.tapconn import TapConn
@@ -1650,23 +1648,28 @@ def delete_user_table(self, table_name=None, force_removal=False,
         msg = f"Table '{table_name}' deleted."
         print(msg)
 
-    def rename_table(self, table_name=None, new_table_name=None, new_column_names_dict={},
+    def rename_table(self, table_name=None, new_table_name=None, new_column_names_dict=None,
                      verbose=False):
+        """ This new method allows you to update the column names of a user table.
+
+        Parameters
+        ----------
+        table_name: str, required
+            old name of the user's table
+        new_table_name: str, required
+            new name of the user's table
+        new_column_names_dict: dict str:str, required
+            dict with pairs "old_column1_name:new_column1_name"
+        verbose : bool, optional, default 'False'
+            flag to display information about the process
+
+        Example
+        -------
+        rename_table(table_name=old_table_name, new_table_name=new_table_name,
+        new_column_names_dict=[old_column1:new_column1, old_column2:new_column2, ...])
         """
-            This new method allows to update the column names of a user table.
-            header example: rename_table(table_name=old_table_name, new_table_name=new_table_name -optional-
-             , new_column_names_dict=[old_column1:new_column1, old_column2:new_colum2...])
-            Parameters
-            ----------
-            table_name: str, required
-                old name of the user's table
-            new_table_name: str, required
-                new name of the user's table
-            new_column_names_dict: dict str:str, required
-                dict with pairs "old_column1_name:new_column1_name"
-            verbose : bool, optional, default 'False'
-                flag to display information about the process
-        """
+        if new_column_names_dict is None:
+            new_column_names_dict = {}
         args = {}
 
         if table_name is None:
@@ -1676,25 +1679,13 @@ def rename_table(self, table_name=None, new_table_name=None, new_column_names_di
             raise ValueError("Please introduce as minimum a new table tame or a new name for a column with format "
                              "old_column1_name:new_column1_name, ... ,old_columnN_name:new_columnN_name")
 
-        # # Now we will check that the table exist
-        # table = self.load_table(table=table_name, verbose=verbose)
-        #
-        # # Check now if the table exist and contains values
-        # if table is None:
-        #     raise ValueError("Table name not found")
-        # columns = table.columns
-        # if len(columns) == 0:
-        #     raise ValueError("Table has no columns")
-
         if new_table_name is not None or new_table_name != '':
             if new_column_names_dict is None or not new_column_names_dict:
                 # case 1: We only need to rename the table
                 args = self.get_args_4_rename_table_only_table_name(table_name, new_table_name)
             else:
                 # case 2: We need to rename both, columns and column name
                 args = self.get_args_4_rename_table_all(table_name, new_table_name, new_column_names_dict)
-            # __end_if
-        # __end_if
 
         if new_table_name is None or new_table_name == '':
             if new_column_names_dict is not None or new_column_names_dict:
@@ -1713,8 +1704,6 @@ def rename_table(self, table_name=None, new_table_name=None, new_column_names_di
         msg = f"Table '{table_name}' updated."
         print(msg)
 
-    # __end_of_rename_table
-
     def get_args_4_rename_table_only_table_name(self, table_name, new_table_name):
 
         args = {
@@ -1724,8 +1713,6 @@ def get_args_4_rename_table_only_table_name(self, table_name, new_table_name):
         }
         return args
 
-    # __end_of_rename_table_only_table_name
-
     def get_args_4_rename_table_all(self, table_name, new_table_name, new_column_names_dict):
         count = 0
         new_column_names = ""
@@ -1755,8 +1742,6 @@ def get_args_4_rename_table_all(self, table_name, new_table_name, new_column_nam
         }
         return args
 
-    # __end_of_rename_table_all
-
     def get_args_4_rename_table_only_columns(self, table_name, new_column_names_dict):
         # check if the changes proposed for the columns are correct.