remove duplicate code & add changelog entry

Author: keflavich

CHANGES

@@ -28,6 +28,8 @@
 0.3.7 (2018-01-25)
 ------------------
 
+- WFAU: New tool / refactor of the UKIDSS query tool [#984].
+- UKIDSS: Update to DR10 as default database [#984].
 - New tool: Exoplanet Orbit Catalog, NASA Exoplanet Archive [#771]
 - ESO: The upstream API changed.  We have adapted.  [#970]
 - ESO: Added 'destination' keyword to Eso.retrieve_data(), to download files

astroquery/ukidss/core.py

@@ -57,14 +57,11 @@ class UkidssClass(BaseWFAUClass):
 
     def __init__(self, username=None, password=None, community=None,
                  database='UKIDSSDR10PLUS', programme_id='all'):
-        super(UkidssClass, self).__init__()
-        self.database = database
-        self.programme_id = programme_id  # 102 = GPS
-        self.session = None
-        if username is None or password is None or community is None:
-            pass
-        else:
-            self.login(username, password, community)
+        super(UkidssClass, self).__init__(database=database,
+                                          programme_id=programme_id,
+                                          username=username,
+                                          community=community,
+                                          password=password)
 
 
 Ukidss = UkidssClass()

astroquery/vsa/core.py

@@ -59,28 +59,16 @@ class VsaClass(BaseWFAUClass):
 
     def __init__(self, username=None, password=None, community=None,
                  database='VVVDR4', programme_id='all'):
-        super(VsaClass, self).__init__()
-        self.database = database
-        self.programme_id = programme_id
-        self.session = None
-        if username is None or password is None or community is None:
-            pass
-        else:
-            self.login(username, password, community)
+        super(VsaClass, self).__init__(database=database,
+                                       programme_id=programme_id,
+                                       username=username,
+                                       community=community,
+                                       password=password)
 
         self.BASE_URL = 'http://horus.roe.ac.uk:8080/vdfs/'
         self.LOGIN_URL = self.BASE_URL + "DBLogin"
         self.IMAGE_URL = self.BASE_URL + "GetImage"
         self.ARCHIVE_URL = self.BASE_URL + "ImageList"
         self.REGION_URL = self.BASE_URL + "WSASQL"
 
-        self.database = database
-        self.programme_id = programme_id
-        self.session = None
-        if username is None or password is None or community is None:
-            pass
-        else:
-            self.login(username, password, community)
-
-
 Vsa = VsaClass()

astroquery/wfau/core.py

@@ -44,7 +44,7 @@ def __init__(self, username=None, password=None, community=None,
         """
         super(BaseWFAUClass, self).__init__()
         self.database = database
-        self.programme_id = programme_id  # 102 = GPS
+        self.programme_id = programme_id
         self.session = None
         if username is None or password is None or community is None:
             pass