apply @eerovaher 's suggestions

Co-authored-by: Eero Vaher <[email protected]>

Author: m-stclair

astroquery/jplhorizons/core.py

@@ -1045,7 +1045,7 @@ def vectors_async(self, *, get_query_payload=False,
         if self.id is None:
             raise ValueError("'id' parameter not set. Query aborted.")
         elif isinstance(self.id, dict):
-            commandline = f"g:{self.id['lon']},{self.id['lat']},{self.id['elevation']}@{self.id['body']}"
+            commandline = "g:{lon},{lat},{elevation}@{body}".format(**self.id)
         else:
             commandline = str(self.id)
         if self.location is None:
@@ -1144,7 +1144,7 @@ def vectors_async(self, *, get_query_payload=False,
     @staticmethod
     def _prep_loc_dict(loc_dict, attr_name):
         """prepare coord specification dict for 'location' or 'id'"""
-        if {'lat', 'lon', 'elevation'} - set(loc_dict.keys()) != set():
+        if {'lat', 'lon', 'elevation'} - loc_dict.keys():
             raise ValueError(
                 f"dict values for '{attr_name}' must contain 'lat', 'lon', "
                 "'elevation' (and optionally 'body')"
@@ -1221,10 +1221,7 @@ def _parse_result(self, response, verbose=None):
                     "Date__(UT)__HR:MN" in line):
                 headerline = str(line).split(',')
                 headerline[2] = 'solar_presence'
-                if 'Earth' in centername:
-                    headerline[3] = 'lunar_presence'
-                else:
-                    headerline[3] = 'interfering_body'
+                    headerline[3] = "lunar_presence" if "Earth" in centername else "interfering_body"
                 headerline[-1] = '_dump'
                 if isinstance(self.id, dict) or str(self.id).startswith('g:'):
                     headerline[4] = 'nearside_flag'

docs/jplhorizons/jplhorizons.rst

@@ -121,7 +121,7 @@ at a particular point in time to the center of the crater Double:
     >>> obj = Horizons(id=double, location=ce_2, epochs=2454483.84247)
     >>> vecs = obj.vectors()
     >>> distance_km = (vecs['x'] ** 2 + vecs['y'] ** 2 + vecs['z'] ** 2) ** 0.5 * 1.496e8
-    >>> print(round(distance_km.value.data[0], 3))
+    >>> print(f"{distance_km.value.data[0]:.3f}")
     181.213
 
 ``epochs`` is either a scalar or list of Julian dates (floats or strings) in the