Changed name of parameter to download_dir

Author: imbasimba

astroquery/esasky/core.py

@@ -278,7 +278,7 @@ def query_region_catalogs(self, position, radius, catalogs=__ALL_STRING,
         return commons.TableList(query_result)
 
     def get_maps(self, query_table_list, missions=__ALL_STRING, 
-                 savename=__MAPS_STRING, cache=True):
+                 download_dir=__MAPS_STRING, cache=True):
         """
         This method takes the dictionary of missions and metadata as returned by 
         query_region_maps and downloads all maps to the selected folder. 
@@ -296,7 +296,7 @@ def get_maps(self, query_table_list, missions=__ALL_STRING,
             Can be either a specific mission or a list of missions (all mission 
             names are found in list_missions()) or 'all' to search in all 
             missions. Defaults to 'all'. 
-        savename : string, optional
+        download_dir : string, optional
             The folder where all downloaded maps should be stored. 
             Defaults to a folder called 'Maps' in the current working directory. 
         cache : bool, optional
@@ -339,11 +339,11 @@ def get_maps(self, query_table_list, missions=__ALL_STRING,
                         self._get_maps_for_mission(
                             sanitized_query_table_list[query_mission], 
                             query_mission, 
-                            savename, 
+                            download_dir, 
                             cache))
                     break
         if (len(sanitized_query_table_list) > 0):
-            log.info("Maps available at %s" %os.path.abspath(savename))
+            log.info("Maps available at %s" %os.path.abspath(download_dir))
         else:
             print("No maps found")
         return maps

docs/esasky/esasky.rst

@@ -215,12 +215,12 @@ dictionary where the used filter is the key and the HDUList is the value.
 	}
 
 Note that the fits files also are stored to disk. By default they are saved to 
-the working directory but the location can be chosen by the savename 
+the working directory but the location can be chosen by the download_dir 
 parameter:
 
 .. code-block:: python
 
-    >>> images = ESASky.get_images("m51", radius="20 arcmin", missions=['Herschel', 'XMM-EPIC'], savename="/home/user/esasky")
+    >>> images = ESASky.get_images("m51", radius="20 arcmin", missions=['Herschel', 'XMM-EPIC'], download_dir="/home/user/esasky")
 
 Get maps
 --------
@@ -232,13 +232,13 @@ it takes a `~astroquery.utils.TableList` instead of position, radius and mission
 .. code-block:: python
 
     >>> table_list = ESASky.query_region_maps("m51", radius="20 arcmin", missions=['Herschel', 'XMM-EPIC'])
-    >>> images = ESASky.get_maps(table_list, savename="/home/user/esasky")
+    >>> images = ESASky.get_maps(table_list, download_dir="/home/user/esasky")
 
 This example is equivalent to:
 
 .. code-block:: python
 
-    >>> images = ESASky.get_images("m51", radius="20 arcmin", missions=['Herschel', 'XMM-EPIC'], savename="/home/user/esasky")
+    >>> images = ESASky.get_images("m51", radius="20 arcmin", missions=['Herschel', 'XMM-EPIC'], download_dir="/home/user/esasky")
 
 
 Reference/API