try to capture bad row warning more cleanly

Author: keflavich

astroquery/exceptions.py

@@ -8,7 +8,8 @@
 __all__ = ['TimeoutError', 'InvalidQueryError', 'RemoteServiceError',
            'TableParseError', 'LoginError', 'ResolverError',
            'NoResultsWarning', 'LargeQueryWarning', 'InputWarning',
-           'AuthenticationWarning', 'MaxResultsWarning', 'CorruptDataWarning']
+           'AuthenticationWarning', 'MaxResultsWarning', 'CorruptDataWarning',
+           'BadRowWarning']
 
 
 class TimeoutError(Exception):
@@ -111,3 +112,11 @@ class EmptyResponseError(ValueError):
     Astroquery error class to be raised when the query returns an empty result
     """
     pass
+
+
+class BadRowWarning(AstropyWarning):
+    """
+    Astroquery warning to be raised if one or more rows in a table are bad, but
+    not all rows are.
+    """
+    pass

astroquery/simbad/tests/test_simbad_remote.py

@@ -10,6 +10,7 @@
 from astroquery.simbad import Simbad
 # Maybe we need to expose SimbadVOTableResult to be in the public API?
 from astroquery.simbad.core import SimbadVOTableResult
+from astroquery.exceptions import BadRowWarning
 
 
 # M42 coordinates
@@ -148,7 +149,8 @@ def test_query_multi_object(self, temp_dir):
         assert len(result) == 2
         assert len(result.errors) == 0
 
-        result = simbad.query_objects(['M32', 'M81', 'gHer'])
+        with pytest.warns(BadRowWarning):
+            result = simbad.query_objects(['M32', 'M81', 'gHer'])
         # 'gHer' is not a valid Simbad identifier - it should be 'g Her' to
         # get the star
         assert len(result) == 2