BUGFIX: ALMA private queries, plus checking that queries succeed

(1) When running `save=True` in GET requests, there was no check that
the request was sucessful - this is fixed.
(2) ALMA queries require passing the username, not the
previously-hard-coded "anonymous", when performing queries & logged in.
So far, there is no way to test for this!

Author: keflavich

astroquery/alma/core.py

@@ -293,11 +293,15 @@ def stage_data(self, uids):
         summary.raise_for_status()
         self._staging_log['json_data'] = json_data = summary.json()
 
+        username = self._username if hasattr(self, '_username') else 'anonymous'
+
         url_decomposed = urlparse(data_page_url)
         base_url = ('{uri.scheme}://{uri.netloc}/'
-                    'dataPortal/requests/anonymous/'
+                    'dataPortal/requests/{username}/'
                     '{staging_page_id}/ALMA'.format(uri=url_decomposed,
-                                                    staging_page_id=dpid))
+                                                    staging_page_id=dpid,
+                                                    username=username,
+                                                   ))
         tbl = self._json_summary_to_table(json_data, base_url=base_url)
 
         # staging_root = BeautifulSoup(data_page.content)
@@ -444,6 +448,7 @@ def _login(self, username, store_password=False):
 
         if authenticated:
             log.info("Authentication successful!")
+            self._username = username
         else:
             log.exception("Authentication failed!")
         # When authenticated, save password in keyring if needed

astroquery/alma/tests/test_alma_remote.py

@@ -70,7 +70,9 @@ def test_stage_data(self, temp_dir):
         assert b'2011.0.00217.S' in result_s['Project code']
         uid = result_s['Asdm uid'][0]
 
-        alma.stage_data([uid])
+        result = alma.stage_data([uid])
+
+        assert os.path.split(result['URL'][0]) == 'uid___A002_X47ed8e_X6c.asdm.sdm.tar'
 
     def test_doc_example(self, temp_dir):
         alma = Alma()

astroquery/query.py

@@ -180,7 +180,8 @@ def _download_file(self, url, local_filepath, timeout=None, auth=None):
         the local ``_session``
         """
         response = self._session.get(url, timeout=timeout, stream=True,
-                                      auth=auth)
+                                     auth=auth)
+        response.raise_for_status()
         if 'content-length' in response.headers:
             length = int(response.headers['content-length'])
         else: