Add modify_unrecognized_table_units() function

Both xmlparser/utils and model/modelutils use this snippet of code, so
pull it out into a separate function

Author: jdavies-st

astroquery/utils/tap/model/modelutils.py

@@ -16,8 +16,8 @@
 """
 
 import os
+
 from astropy.table import Table as APTable
-from astropy import units as u, io
 
 from astroquery.utils.tap.xmlparser import utils
 
@@ -39,15 +39,7 @@ def read_results_table_from_file(file_name, output_format, correct_units=True):
         result = APTable.read(file_name, format=astropy_format)
 
         if correct_units:
-            for cn in result.colnames:
-                col = result[cn]
-                if isinstance(col.unit, u.UnrecognizedUnit):
-                    try:
-                        col.unit = u.Unit(col.unit.name.replace(".", " ").replace("'", ""))
-                    except Exception as ex:
-                        pass
-                elif isinstance(col.unit, str):
-                    col.unit = col.unit.replace(".", " ").replace("'", "")
+            utils.modify_unrecognized_table_units(result)
 
         return result
     else:

astroquery/utils/tap/xmlparser/utils.py

@@ -38,15 +38,7 @@ def read_http_response(response, output_format, correct_units=True):
         pass
 
     if correct_units:
-        for cn in result.colnames:
-            col = result[cn]
-            if isinstance(col.unit, u.UnrecognizedUnit):
-                try:
-                    col.unit = u.Unit(col.unit.name.replace(".", " ").replace("'", ""))
-                except Exception as ex:
-                    pass
-            elif isinstance(col.unit, str):
-                col.unit = col.unit.replace(".", " ").replace("'", "")
+        modify_unrecognized_table_units(result)
 
     return result
 
@@ -66,3 +58,17 @@ def read_file_content(file_path):
     file_content = file_handler.read()
     file_handler.close()
     return file_content
+
+
+def modify_unrecognized_table_units(table):
+    """Modifies the units of an input table column in place
+    """
+    for cn in table.colnames:
+        col = table[cn]
+        if isinstance(col.unit, u.UnrecognizedUnit):
+            try:
+                col.unit = u.Unit(col.unit.name.replace(".", " ").replace("'", ""))
+            except Exception:
+                pass
+        elif isinstance(col.unit, str):
+            col.unit = col.unit.replace(".", " ").replace("'", "")