Skip to content

Commit 75596bd

Browse files
committed
no no... the default was what it was supposed to be. But the test
works. Splatalogue server no longer supports version selection
1 parent 7cc095f commit 75596bd

File tree

2 files changed

+16
-14
lines changed

2 files changed

+16
-14
lines changed

astroquery/splatalogue/core.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ def _parse_kwargs(self, min_frequency=None, max_frequency=None,
123123
chem_re_flags=0, energy_min=None, energy_max=None,
124124
energy_type=None, intensity_lower_limit=None,
125125
intensity_type=None, transition=None, version=None,
126-
exclude='none', only_NRAO_recommended=None,
126+
exclude=None, only_NRAO_recommended=None,
127127
line_lists=None, line_strengths=None, energy_levels=None,
128128
export=None, export_limit=None, noHFS=None,
129129
displayHFS=None, show_unres_qn=None,

astroquery/splatalogue/tests/test_splatalogue.py

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -107,23 +107,25 @@ def test_band_crashorno():
107107
assert exc.value.args[0] == "Invalid frequency band."
108108

109109

110-
# regression test : version selection should work
111-
# Unfortunately, it looks like version1 = version2 on the web page now, so this
112-
# may no longer be a valid test
113-
@remote_data
114-
def test_version_selection():
115-
results = splatalogue.Splatalogue.query_lines(
116-
min_frequency= 703*u.GHz,
117-
max_frequency=706*u.GHz,
118-
chemical_name='Acetaldehyde',
119-
version='v1.0'
120-
)
121-
assert len(results)==1
110+
#Upstream changed: there is no distinction between versions for this molecule
111+
# # regression test : version selection should work
112+
# # Unfortunately, it looks like version1 = version2 on the web page now, so this
113+
# # may no longer be a valid test
114+
# @remote_data
115+
# def test_version_selection():
116+
# results = splatalogue.Splatalogue.query_lines(
117+
# min_frequency= 703*u.GHz,
118+
# max_frequency=706*u.GHz,
119+
# chemical_name='Acetaldehyde',
120+
# version='v1.0'
121+
# )
122+
# assert len(results)==1
122123

123124
def test_exclude(patch_post):
124125
# regression test for issue 616
125126
d = splatalogue.Splatalogue.query_lines_async(114 * u.GHz, 116 * u.GHz,
126127
chemical_name=' CO ',
128+
exclude=None,
127129
get_query_payload=True)
128130

129131
exclusions = {'no_atmospheric': 'no_atmospheric',
@@ -155,7 +157,7 @@ def test_exclude_remote():
155157
energy_type='eu_k',
156158
line_lists=['CDMS'],
157159
export_limit=1000.,
158-
exclude=None,
160+
exclude='none',
159161
version='v2.0',
160162
show_upper_degeneracy=True,
161163
)

0 commit comments

Comments
 (0)