Merge pull request #1936 from pllim/tst-cron

TST: Add remote data cron job, minor workflow clean-ups

Author: bsipocz

.github/workflows/ci_tests.yml

@@ -2,14 +2,17 @@ name: CI
 
 on:
   push:
+    branches:
+    - master
+    tags:
+    - '*'
   pull_request:
+    branches:
+    - master
   schedule:
     # run every Monday at 5am UTC
     - cron: '0 5 * * 1'
 
-env:
-  TOXARGS: '-v'
-
 jobs:
   tests:
     name: ${{ matrix.name }}
@@ -28,26 +31,31 @@ jobs:
             os: ubuntu-latest
             python: 3.8
             toxenv: build_docs
+            toxargs: -v
 
           - name: oldest dependencies
             os: ubuntu-latest
             python: 3.6
             toxenv: py36-test-oldestdeps
+            toxargs: -v
 
           - name: astropy dev with all dependencies with coverage
             os: ubuntu-latest
             python: 3.9
             toxenv: py39-test-alldeps-devastropy-cov
+            toxargs: -v
 
           - name: Python 3.7 with all optional dependencies (MacOS X)
             os: macos-latest
             python: 3.7
             toxenv: py37-test-alldeps
+            toxargs: -v
 
           - name: Python 3.8 with mandatory dependencies (Windows)
             os: windows-latest
             python: 3.8
             toxenv: py38-test
+            toxargs: -v
 
     steps:
     - name: Checkout code
@@ -59,15 +67,35 @@ jobs:
       with:
         python-version: ${{ matrix.python }}
     - name: Install Python dependencies
-      run: python -m pip install --upgrade tox codecov
+      run: python -m pip install --upgrade tox
     - name: Run tests
-      run: tox ${{ matrix.toxargs }} -e ${{ matrix.toxenv }}
+      run: tox ${{ matrix.toxargs }} -e ${{ matrix.toxenv }} -- ${{ matrix.toxposargs }}
     - name: Upload coverage to codecov
-      if: ${{ contains(matrix.toxenv,'-cov') }}
+      if: contains(matrix.toxenv,'-cov')
       uses: codecov/codecov-action@v1
       with:
         file: ./coverage.xml
 
+  # This needs to be outside of matrix because if is not supported
+  # for only one job in a matrix. But once that is supported, this can go
+  # back to the matrix above.
+  remote_data:
+    name: Python 3.8 with all dependencies with remote data
+    if: github.event_name == 'schedule' && github.repository == 'astropy/astroquery'
+    runs-on: ubuntu-latest
+    steps:
+    - name: Checkout code
+      uses: actions/checkout@v2
+      with:
+        fetch-depth: 0
+    - name: Set up Python
+      uses: actions/setup-python@v2
+      with:
+        python-version: '3.8'
+    - name: Install Python dependencies
+      run: python -m pip install --upgrade tox
+    - name: Run tests
+      run: tox -v -e py38-test-alldeps-devastropy -- --remote-data
 
   egg_info:
     name: egg_info with Python 3.7

tox.ini

@@ -9,7 +9,6 @@ requires =
     tox-pypi-filter >= 0.12
 isolated_build = true
 
-
 [testenv]
 
 # The following option combined with the use of the tox-pypi-filter above allows
@@ -33,6 +32,8 @@ deps =
 # TODO: Add more versions to oldestdeps
     oldestdeps: astropy==3.1
 
+    cov: codecov
+
 extras =
     test
     !py39-alldeps: all_lt_39
@@ -41,9 +42,9 @@ extras =
 commands =
     pip freeze
 # FIXME: there are too many failures from the docs example gallery ignore docs for now
-# !cov: pytest {toxinidir}/astroquery {toxinidir}/docs
-    !cov: pytest {toxinidir}/astroquery
-    cov:  pytest {toxinidir}/astroquery --cov {toxinidir}/astroquery
+# !cov: pytest {toxinidir}/astroquery {toxinidir}/docs {posargs}
+    !cov: pytest {toxinidir}/astroquery {posargs}
+    cov:  pytest {toxinidir}/astroquery --cov {toxinidir}/astroquery {posargs}
     cov: coverage xml -o {toxinidir}/coverage.xml
 
 [testenv:codestyle]
@@ -53,9 +54,8 @@ description = check code style
 deps = pycodestyle
 commands = pycodestyle astroquery --count
 
-
 [testenv:build_docs]
-changedir =
+changedir = {toxinidir}
 description = Building the narrative and API docs
 extras = docs
 requires =