Skip to content

Commit 7f4859c

Browse files
committed
Use full variable name
1 parent 302f889 commit 7f4859c

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

astroquery/mast/observations.py

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1121,15 +1121,15 @@ def service_request_async(self, service, params, *, pagesize=None, page=None, **
11211121

11221122
return self._portal_api_connection.service_request_async(service, params, pagesize, page, **kwargs)
11231123

1124-
def _normalize_filter_value(self, key: str, val) -> list:
1124+
def _normalize_filter_value(self, key: str, value) -> list:
11251125
"""
11261126
Normalize a filter value into a list suitable for MAST filters.
11271127
11281128
Parameters
11291129
----------
11301130
key : str
11311131
Parameter name (used for error messages).
1132-
val : any
1132+
value : any
11331133
Raw filter value.
11341134
11351135
Returns
@@ -1138,23 +1138,23 @@ def _normalize_filter_value(self, key: str, val) -> list:
11381138
Normalized filter values.
11391139
"""
11401140
# Range filters must be dicts with 'min' and 'max'
1141-
if isinstance(val, dict):
1142-
if not {"min", "max"}.issubset(val.keys()):
1141+
if isinstance(value, dict):
1142+
if not {"min", "max"}.issubset(value.keys()):
11431143
raise InvalidQueryError(
11441144
f'Range filter for "{key}" must be a dictionary with "min" and "max" keys.'
11451145
)
1146-
return [val]
1146+
return [value]
11471147

11481148
# Convert numpy arrays to lists
1149-
if isinstance(val, np.ndarray):
1150-
val = val.tolist()
1149+
if isinstance(value, np.ndarray):
1150+
value = value.tolist()
11511151

11521152
# Convert numpy arrays, sets, or tuples to lists
1153-
if isinstance(val, (set, tuple)):
1154-
val = list(val)
1153+
if isinstance(value, (set, tuple)):
1154+
value = list(value)
11551155

11561156
# Wrap scalars into a list
1157-
return val if isinstance(val, list) else [val]
1157+
return value if isinstance(value, list) else [value]
11581158

11591159
def _build_filters(self, service_params):
11601160
"""
@@ -1171,10 +1171,10 @@ def _build_filters(self, service_params):
11711171
Filters suitable for a MAST filtered query.
11721172
"""
11731173
filters = []
1174-
for key, val in service_params.items():
1174+
for key, value in service_params.items():
11751175
filters.append({
11761176
"paramName": key,
1177-
"values": self._normalize_filter_value(key, val)
1177+
"values": self._normalize_filter_value(key, value)
11781178
})
11791179
return filters
11801180

0 commit comments

Comments
 (0)