Skip to content

Commit 85d1cd3

Browse files
authored
Merge pull request #3325 from bsipocz/MAINT_astropy_7.1.1_compat
MAINT: astropy 7.1.1 compatibility in tests
2 parents 660eb7d + 125366d commit 85d1cd3

File tree

3 files changed

+22
-20
lines changed

3 files changed

+22
-20
lines changed

astroquery/esa/euclid/tests/test_euclidtap.py

Lines changed: 12 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424

2525
from astroquery.esa.euclid.core import EuclidClass
2626
from astroquery.esa.euclid.core import conf
27+
from astroquery.utils.commons import ASTROPY_LT_7_1_1
2728
from astroquery.utils.tap.conn.tests.DummyConnHandler import DummyConnHandler
2829
from astroquery.utils.tap.conn.tests.DummyResponse import DummyResponse
2930
from astroquery.utils.tap.core import TapPlus
@@ -116,7 +117,10 @@ def column_attrs():
116117
}
117118
columns = {k: Column(name=k, description=k, dtype=v) for k, v in dtypes.items()}
118119

119-
columns["source_id"].meta = {"_votable_string_dtype": "char"}
120+
if ASTROPY_LT_7_1_1:
121+
columns["source_id"].meta = {"_votable_string_dtype": "char"}
122+
else:
123+
columns["source_id"].meta = {"_votable_string_dtype": "char", "_votable_arraysize": "*"}
120124
return columns
121125

122126

@@ -201,36 +205,26 @@ def test_query_object_async_radius(column_attrs, mock_querier_async):
201205
for colname, attrs in column_attrs.items():
202206
assert table[colname].attrs_equal(attrs)
203207

204-
def test_query_object_radius(column_attrs, mock_querier):
205-
coord = SkyCoord(ra=60.3372780005097, dec=-49.93184727724773, unit=(u.degree, u.degree), frame='icrs')
206-
table = mock_querier.query_object(coordinate=coord, radius=RADIUS)
207208

208-
assert table is not None
209-
210-
assert len(table) == 3
211-
for colname, attrs in column_attrs.items():
212-
assert table[colname].attrs_equal(attrs)
213-
214-
215-
def test_query_object_async_radius_columns(column_attrs, mock_querier_async):
209+
def test_query_object_radius(column_attrs, mock_querier):
216210
coord = SkyCoord(ra=60.3372780005097, dec=-49.93184727724773, unit=(u.degree, u.degree), frame='icrs')
217-
table = mock_querier_async.query_object(coordinate=coord, radius=RADIUS, columns=("alpha",), async_job=True)
211+
table = mock_querier.query_object(coordinate=coord, radius=RADIUS)
218212

219213
assert table is not None
220214

221215
assert len(table) == 3
222-
assert table["alpha"].attrs_equal(column_attrs["alpha"])
216+
for colname, attrs in column_attrs.items():
217+
assert table[colname].attrs_equal(attrs)
223218

224219

225-
def test_query_object_radius(column_attrs, mock_querier):
220+
def test_query_object_async_radius_columns(column_attrs, mock_querier_async):
226221
coord = SkyCoord(ra=60.3372780005097, dec=-49.93184727724773, unit=(u.degree, u.degree), frame='icrs')
227-
table = mock_querier.query_object(coordinate=coord, radius=RADIUS)
222+
table = mock_querier_async.query_object(coordinate=coord, radius=RADIUS, columns=("alpha",), async_job=True)
228223

229224
assert table is not None
230225

231226
assert len(table) == 3
232-
for colname, attrs in column_attrs.items():
233-
assert table[colname].attrs_equal(attrs)
227+
assert table["alpha"].attrs_equal(column_attrs["alpha"])
234228

235229

236230
def test_query_object_radius_columns(column_attrs, mock_querier):

astroquery/gaia/tests/test_gaiatap.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131

3232
from astroquery.gaia import conf
3333
from astroquery.gaia.core import GaiaClass
34+
from astroquery.utils.commons import ASTROPY_LT_7_1_1
3435
from astroquery.utils.tap.conn.tests.DummyConnHandler import DummyConnHandler
3536
from astroquery.utils.tap.conn.tests.DummyResponse import DummyResponse
3637
from astroquery.utils.tap.core import TapPlus
@@ -112,9 +113,14 @@ def column_attrs():
112113
"source_id": object,
113114
"table1_oid": np.int32
114115
}
116+
115117
columns = {k: Column(name=k, description=k, dtype=v) for k, v in dtypes.items()}
116118

117-
columns["source_id"].meta = {"_votable_string_dtype": "char"}
119+
if ASTROPY_LT_7_1_1:
120+
columns["source_id"].meta = {"_votable_string_dtype": "char"}
121+
else:
122+
columns["source_id"].meta = {"_votable_string_dtype": "char", "_votable_arraysize": "*"}
123+
118124
return columns
119125

120126

astroquery/utils/commons.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,13 @@
3131
'validate_email',
3232
'ASTROPY_LT_5_1',
3333
'ASTROPY_LT_5_3',
34-
'ASTROPY_LT_6_0']
34+
'ASTROPY_LT_6_0',
35+
'ASTROPY_LT_7_1_1']
3536

3637
ASTROPY_LT_5_1 = not minversion('astropy', '5.1')
3738
ASTROPY_LT_5_3 = not minversion('astropy', '5.3')
3839
ASTROPY_LT_6_0 = not minversion('astropy', '6.0')
40+
ASTROPY_LT_7_1_1 = not minversion('astropy', '7.1.1')
3941

4042

4143
def parse_coordinates(coordinates):

0 commit comments

Comments
 (0)