Changelog, fix test error

Author: snbianco

CHANGES.rst

@@ -183,6 +183,9 @@ mast
 - Increased the speed of ``mast.Observations.get_cloud_uris`` by obtaining multiple
   URIs from MAST at once. [#3064]
 
+- Present users with an error rather than a warning when nonexistent query criteria are used in ``mast.Observations.query_criteria``
+  and ``mast.Catalogs.query_criteria``. [#3084]
+
 
 0.4.7 (2024-03-08)
 ==================

astroquery/mast/discovery_portal.py

@@ -407,8 +407,8 @@ def build_filter_set(self, column_config_name, service_name=None, **filters):
             # Get the column type and separator
             col_info = caom_col_config.get(colname)
             if not col_info:
-                closest_match = difflib.get_close_matches(colname, caom_col_config.keys(), n=1)[0]
-                error_msg = f"Filter '{colname}' does not exist. Did you mean '{closest_match}'?" if closest_match \
+                closest_match = difflib.get_close_matches(colname, caom_col_config.keys(), n=1)
+                error_msg = f"Filter '{colname}' does not exist. Did you mean '{closest_match[0]}'?" if closest_match \
                     else f"Filter '{colname}' does not exist."
                 raise InvalidQueryError(error_msg)
 

astroquery/mast/tests/test_mast_remote.py

@@ -278,7 +278,7 @@ def test_observations_query_criteria_invalid_keyword(self):
         # attempt to make a criteria query with invalid keyword
         with pytest.raises(InvalidQueryError) as err_no_alt:
             Observations.query_criteria_count(not_a_keyword='TESS')
-        assert 'Filter not_a_keyword does not exist.' in str(err_no_alt.value)
+        assert "Filter 'not_a_keyword' does not exist." in str(err_no_alt.value)
 
         # keyword is close enough for difflib to offer alternative
         with pytest.raises(InvalidQueryError) as err_with_alt:
@@ -896,7 +896,7 @@ def test_catalogs_query_criteria_invalid_keyword(self):
         # attempt to make a criteria query with invalid keyword
         with pytest.raises(InvalidQueryError) as err_no_alt:
             Catalogs.query_criteria(catalog='tic', not_a_keyword='TESS')
-        assert 'Filter not_a_keyword does not exist.' in str(err_no_alt.value)
+        assert "Filter 'not_a_keyword' does not exist." in str(err_no_alt.value)
 
         # keyword is close enough for difflib to offer alternative
         with pytest.raises(InvalidQueryError) as err_with_alt: