GAIAMNGT-1700 Remove test

Author: Jorge Fernandez Hernandez

astroquery/gaia/core.py

@@ -242,7 +242,8 @@ def load_data(self, ids, *, data_release=None, data_structure='INDIVIDUAL', retr
             log.info(f"DataLink products will be stored in the {output_file} file")
 
             if not overwrite_output_file and os.path.exists(output_file):
-                log.warn(f"{output_file} file already exists and will be overwritten")
+                raise ValueError(f"{output_file} file already exists. Please use overwrite_output_file='True' to "
+                                 f"overwrite output file.")
 
         path = os.path.dirname(output_file)
 

astroquery/gaia/tests/test_gaiatap.py

@@ -781,24 +781,6 @@ def test_cone_search_and_changing_MAIN_GAIA_TABLE(mock_querier_async):
         assert "name_from_class" in job.parameters["query"]
 
 
-def test_datalink_querier_load_data_no_dump_vot(mock_datalink_querier):
-    result_dict = mock_datalink_querier.load_data(ids=[5937083312263887616], data_release='Gaia DR3',
-                                                  data_structure='INDIVIDUAL',
-                                                  retrieval_type="ALL",
-                                                  linking_parameter='SOURCE_ID', valid_data=False, band=None,
-                                                  avoid_datatype_check=False,
-                                                  format="votable", dump_to_file=False, overwrite_output_file=True,
-                                                  verbose=False)
-
-    assert len(result_dict) == 3
-
-    files = list(result_dict.keys())
-    files.sort()
-    assert files[0] == 'MCMC_MSC-Gaia DR3 5937083312263887616.xml'
-    assert files[1] == 'XP_CONTINUOUS-Gaia DR3 5937083312263887616.xml'
-    assert files[2] == 'XP_SAMPLED-Gaia DR3 5937083312263887616.xml'
-
-
 def test_datalink_querier_load_data_vot(mock_datalink_querier):
     result_dict = mock_datalink_querier.load_data(ids=[5937083312263887616], data_release='Gaia DR3',
                                                   data_structure='INDIVIDUAL',
@@ -808,7 +790,7 @@ def test_datalink_querier_load_data_vot(mock_datalink_querier):
                                                   format="votable", dump_to_file=True, overwrite_output_file=True,
                                                   verbose=False)
 
-    assert os.path.exists('datalink_output.zip')
+    assert os.path.exists(os.path.join(os.getcwd(), 'datalink_output.zip'))
 
     extracted_files = []
 
@@ -827,7 +809,7 @@ def test_datalink_querier_load_data_vot(mock_datalink_querier):
 
     os.remove(os.path.join(os.getcwd(), 'datalink_output.zip'))
 
-    assert not os.path.exists('datalink_output.zip')
+    assert not os.path.exists(os.path.join(os.getcwd(), 'datalink_output.zip'))
 
 
 def test_datalink_querier_load_data_ecsv(mock_datalink_querier_ecsv):