Merge pull request #2752 from mwcraig/update-astrometry-net-tests-and-omg-bug

Update astrometry.net tests and address bug

Author: bsipocz

CHANGES.rst

@@ -89,6 +89,12 @@ astrometry_net
 
 - Added ``return_submission_id`` keyword argument to ``monitor_submission()``. [#2685]
 
+- Fixed off-by-one error in the reference pixel of the WCS solution when the
+  solution is found using sources detected by photutils. After this fix the
+  solution from astrometry.net will be the same when the input is an image
+  regardless of whether the image is uploaded or sources are detected
+  locally. [#2752]
+
 cadc
 ^^^^
 

astroquery/astrometry_net/core.py

@@ -15,7 +15,7 @@
     _HAVE_CCDDATA = True
 
 try:
-    from photutils import DAOStarFinder
+    from photutils.detection import DAOStarFinder
 except ImportError:
     _HAVE_SOURCE_DETECTION = False
 else:
@@ -441,6 +441,10 @@ def solve_from_image(self, image_file_path, *, force_image_upload=False,
             sources.reverse()
             if verbose:
                 print(sources)
+
+            # It turns out astrometry.net is 1-indexed, so add 1 to the source positions.
+            sources['xcentroid'] += 1
+            sources['ycentroid'] += 1
             return self.solve_from_source_list(sources['xcentroid'],
                                                sources['ycentroid'],
                                                ccd.header['naxis1'],