fix: rename C into sky

this makes this parameter different from the one the server understands, but it's more consistant with the other possible values for spacesys

Author: ManonMarchand

astroquery/mocserver/core.py

@@ -75,7 +75,7 @@ def query_region(
             fields. The complete list of fields can be obtained with `list_fields`.
         spacesys: str, optional
             This is the space system on which the coordinates are expressed. Can take
-            the values ``C`` (for the sky), ``mars``, ``moon``... The extended list can
+            the values ``sky``, ``mars``, ``moon``... The extended list can
             be printed with `list_spacesys`. Default is None, meaning that the results
             will have mixed frames.
         intersect : str, optional
@@ -162,7 +162,7 @@ def query_hips(
             fields. The complete list of fields can be obtained with `list_fields`.
         spacesys: str, optional
             This is the space system on which the coordinates are expressed. Can take
-            the values ``C`` (for the sky), ``mars``, ``moon``... The extended list can
+            the values ``sky``, ``mars``, ``moon``... The extended list can
             be printed with `list_spacesys`. Default is None, meaning that the results
             will have mixed frames.
         region : `regions.CircleSkyRegion`, `regions.PolygonSkyRegion`, `mocpy.MOC`,
@@ -254,7 +254,7 @@ def find_datasets(
             fields. The complete list of fields can be obtained with `list_fields`.
         spacesys: str, optional
             This is the space system on which the coordinates are expressed. Can take
-            the values ``C`` (for the sky), ``mars``, ``moon``... The extended list can
+            the values ``sky``, ``mars``, ``moon``... The extended list can
             be printed with `list_spacesys`. Default is None, meaning that the results
             will have mixed frames.
         region : `regions.CircleSkyRegion`, `regions.PolygonSkyRegion`, `mocpy.MOC`,
@@ -342,7 +342,7 @@ def query_async(
             fields. The complete list of fields can be obtained with `list_fields`.
         spacesys: str, optional
             This is the space system on which the coordinates are expressed. Can take
-            the values ``C`` (for the sky), ``mars``, ``moon``... The extended list can
+            the values ``sky``, ``mars``, ``moon``... The extended list can
             be printed with `list_spacesys`. Default is None, meaning that the results
             will have mixed frames.
         region : `regions.CircleSkyRegion`, `regions.PolygonSkyRegion`, `mocpy.MOC`,
@@ -521,7 +521,7 @@ def list_spacesys(self):
                                             fields=["ID", "hips_frame"],
                                             spacesys=None)["hips_frame"]))
         # `C` is a special case that corresponds to both equatorial and galactic frames
-        frames.append("C")
+        frames.append("sky")
         frames.sort()
         return frames
 
@@ -553,7 +553,7 @@ def _args_to_payload(
         "get": "record",
         "fields": _get_fields(fields, default_fields),
         "intersect": intersect.replace("encloses", "enclosed"),
-        "spacesys": spacesys,
+        "spacesys": "C" if spacesys == "sky" else spacesys,
     }
 
     if region and not isinstance(region, (MOC, STMOC, TimeMOC)):

astroquery/mocserver/tests/test_mocserver.py

@@ -153,7 +153,7 @@ def _mock_list_spacesys(monkeypatch):
 @pytest.mark.usefixtures("_mock_list_spacesys")
 def test_list_spacesys():
     list_spacesys = MOCServer.list_spacesys()
-    assert "C" in list_spacesys and "equatorial" in list_spacesys
+    assert "sky" in list_spacesys and "equatorial" in list_spacesys
 
 
 # ---------------------
@@ -224,6 +224,14 @@ def test_return_moc():
     assert payload["order"] == "max"
 
 
+def test_spacesys():
+    payload = MOCServer.query_region(
+        spacesys="sky", meta_data="", return_moc=True,
+        max_norder=5, get_query_payload=True
+    )
+    assert payload["spacesys"] == "C"
+
+
 # ----------------
 # Helper functions
 # ----------------

docs/mocserver/mocserver.rst

@@ -362,10 +362,12 @@ sky and all other possible frames. This can take all the values listed by
 
   >>> from astroquery.mocserver import MOCServer
   >>> MOCServer.list_spacesys()
-  ['C', 'ariel', 'callisto', 'ceres', 'charon', 'dione', 'earth', 'enceladus', 'equatorial', 'europa', 'galactic', 'ganymede', 'iapetus', 'io', 'jupiter', 'mars', 'mars-pia20284', 'mars-pia24422', 'mars-stimson', 'mercury', 'mimas', 'miranda', 'moon', 'moon-pan1', 'neptune', 'oberon', 'pluto', 'rhea', 'sun', 'tethys', 'titan', 'titania', 'triton', 'umbriel', 'venus']
+  ['ariel', 'callisto', 'ceres', 'charon', 'dione', 'earth', 'enceladus', 'equatorial', 'europa', 'galactic', 'ganymede', 'iapetus', 'io', 'jupiter', 'mars', 'mars-pia20284', 'mars-pia24422', 'mars-stimson', 'mercury', 'mimas', 'miranda', 'moon', 'moon-pan1', 'neptune', 'oberon', 'pluto', 'rhea', 'sky', 'sun', 'tethys', 'titan', 'titania', 'triton', 'umbriel', 'venus']
 
-Where the special value ``C`` means any celestial frame (mainly ``equatorial`` and
-``galactic``). This can be used in any of the query methods like so:
+Where the special value ``sky`` means any celestial frame (mainly ``equatorial`` and
+``galactic``). 
+
+The ``spacesys`` can be used in any of the query methods like so:
 
 .. doctest-remote-data::