fix for issue 2139: add an ability to remove the cache file if a failed

query occurs (the query succeeded but was unparseable)

Author: keflavich

astroquery/query.py

@@ -115,6 +115,20 @@ def from_cache(self, cache_location):
             log.debug("Retrieving data from {0}".format(request_file))
         return response
 
+    def remove_cache_file(self, cache_location):
+        """
+        Remove the cache file - may be needed if a query fails during parsing
+        (successful request, but failed return)
+        """
+        request_file = self.request_file(cache_location)
+
+        if os.path.exists(request_file):
+            os.remove(request_file)
+        else:
+            raise OSError(f"Tried to remove cache file {request_file} but "
+                          "it does not exist")
+
+
 
 class LoginABCMeta(abc.ABCMeta):
     """

astroquery/simbad/core.py

@@ -928,6 +928,7 @@ def query_objectids(self, object_name, verbose=False, cache=True,
         return self._parse_result(response, SimbadObjectIDsResult,
                                   verbose=verbose)
 
+
     def query_objectids_async(self, object_name, cache=True,
                               get_query_payload=False):
         """
@@ -1055,6 +1056,12 @@ def _parse_result(self, result, resultclass=SimbadVOTableResult,
                 return None
         except Exception as ex:
             self.last_table_parse_error = ex
+            try:
+                self._last_query.remove_cache_file(self.cache_location)
+            except OSError:
+                # this is allowed: if `cache` was set to False, this
+                # won't be needed
+                pass
             raise TableParseError("Failed to parse SIMBAD result! The raw "
                                   "response can be found in "
                                   "self.last_response, and the error in "