Skip to content

Commit c3632e3

Browse files
committed
Add tests for SimbadClass.query_region_async
The new tests reveal a problem when radius is passed as a `str` and multiple coordinates are specified.
1 parent 52c0e5c commit c3632e3

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

astroquery/simbad/tests/test_simbad.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -243,6 +243,7 @@ def test_query_catalog(patch_post):
243243
(FK4_COORDS, '5d0m0s', 2000.0, 'J2000'),
244244
(FK5_COORDS, None, 2000.0, 'J2000'),
245245
(multicoords, 0.5*u.arcsec, 2000.0, 'J2000'),
246+
(multicoords, "0.5s", 2000.0, 'J2000'),
246247
])
247248
def test_query_region_async(patch_post, coordinates, radius, equinox, epoch):
248249
response1 = simbad.core.Simbad.query_region_async(

astroquery/simbad/tests/test_simbad_remote.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,10 +107,11 @@ def test_query_region_async(self, temp_dir):
107107

108108
assert response is not None
109109

110-
def test_query_region_async_vector(self, temp_dir):
110+
@pytest.mark.parametrize("radius", (0.5 * u.arcsec, "0.5s"))
111+
def test_query_region_async_vector(self, temp_dir, radius):
111112
simbad = Simbad()
112113
simbad.cache_location = temp_dir
113-
response1 = simbad.query_region_async(multicoords, radius=0.5*u.arcsec)
114+
response1 = simbad.query_region_async(multicoords, radius=radius)
114115
assert response1.request.body == 'script=votable+%7Bmain_id%2Ccoordinates%7D%0Avotable+open%0Aquery+coo+5%3A35%3A17.3+-80%3A52%3A00+radius%3D0.5s+frame%3DICRS+equi%3D2000.0%0Aquery+coo+17%3A47%3A20.4+-28%3A23%3A07.008+radius%3D0.5s+frame%3DICRS+equi%3D2000.0%0Avotable+close' # noqa
115116

116117
def test_query_region(self, temp_dir):

0 commit comments

Comments
 (0)