Deprecate astroquery/utils/download_file_list.py

This commit deprecates the function `download_list_of_fitsfiles()`, and
because that is the only public function defined by the aforementioned
file then the whole file becomes deprecated.

Author: eerovaher

astroquery/utils/download_file_list.py

@@ -6,6 +6,7 @@
 from io import StringIO
 
 import astropy.io.fits as fits
+from astropy.utils.decorators import deprecated
 from .commons import get_readable_fileobj
 
 __all__ = ['download_list_of_fitsfiles']
@@ -26,6 +27,7 @@ def validify_filename(filestr):
     return filestr
 
 
+@deprecated('0.4.5')
 def download_list_of_fitsfiles(linklist, output_directory=None,
                                output_prefix=None, save=False,
                                overwrite=False, verbose=False,

astroquery/utils/tests/test_download_file_list.py

@@ -0,0 +1,10 @@
+import pytest
+
+from astropy.utils.exceptions import AstropyDeprecationWarning
+
+from astroquery.utils.download_file_list import download_list_of_fitsfiles
+
+
+def test_download_list_of_fitsfiles_deprecation():
+    with pytest.warns(AstropyDeprecationWarning):
+        download_list_of_fitsfiles([])