Merge pull request #2070 from bsipocz/vamdc_deprecate

Deprecate astroquery.vamdc

Author: bsipocz

CHANGES.rst

@@ -157,6 +157,12 @@ ukidss
 
 - Updated to ``UKIDSSDR11PLUS`` as the default data release. [#1767]
 
+vamdc
+^^^^^
+
+- Deprecate module due to upstream library dependence and compability
+  issues. [#2070]
+
 vizier
 ^^^^^^
 

astroquery/vamdc/core.py

@@ -8,10 +8,14 @@
 from ..query import BaseQuery
 from . import conf
 from . load_species_table import species_lookuptable
+from astropy.utils.decorators import deprecated
 
 __doctest_skip__ = ['VamdcClass.*']
 
 
+@deprecated('0.4.2', 'the module relies on an unmaintained library and is'
+            'considered deprecated until completely refactored or upstream'
+            'is stablised.')
 @async_to_sync
 class VamdcClass(BaseQuery):
 

astroquery/vamdc/tests/test_vamdc.py

@@ -7,6 +7,7 @@
 # remote_data decorator from astropy:
 
 import pytest
+from astropy.utils.exceptions import AstropyDeprecationWarning
 
 try:
     from ... import vamdc
@@ -23,3 +24,8 @@ class TestVamdcClass:
     def test_query_molecule(self):
         ch3oh = vamdc.core.VamdcClass().query_molecule('CH3OH')
         assert 'SCDMS-2369983' in ch3oh.data['States']
+
+
+def test_deprecation():
+    with pytest.warns(AstropyDeprecationWarning):
+        vamdc.Vamdc(doimport=False)

astroquery/vamdc/tests/test_vamdc_remote.py

@@ -152,7 +152,6 @@ all=
    astropy-healpix
    boto3
    regions
-   vamdclib @ git+https://github.com/keflavich/vamdclib-1.git
 # aplpy is not py39 compatible (it requires shapely that doesn't compile
 # pyregion is not py39 compatible
 all_lt_39=
@@ -162,4 +161,3 @@ all_lt_39=
    astropy-healpix
    aplpy
    boto3
-   vamdclib @ git+https://github.com/keflavich/vamdclib-1.git