Merge pull request #2604 from bsipocz/MAINT_ignore_warninng

MAINT: do the warning ignore in test

Author: bsipocz

astroquery/cadc/tests/test_cadctap.py

@@ -1,7 +1,7 @@
 # Licensed under a 3-clause BSD style license - see LICENSE.rst
 """
 =============
-CadcClass TAP plus
+CadcClass TAP
 =============
 
 """
@@ -20,13 +20,20 @@
 from astropy import units as u
 import pytest
 import requests
+import warnings
 
 from pyvo.auth import securitymethods
 from astroquery.cadc import Cadc, conf
 import astroquery.cadc.core as cadc_core
 
 from unittest.mock import Mock, patch, PropertyMock
 
+try:
+    # workaround for https://github.com/astropy/astroquery/issues/2523 to support bs4<4.11
+    from bs4.builder import XMLParsedAsHTMLWarning
+except ImportError:
+    XMLParsedAsHTMLWarning = None
+
 
 def data_path(filename):
     data_dir = os.path.join(os.path.dirname(__file__), 'data')
@@ -191,9 +198,14 @@ def raise_for_status(self):
     with patch.object(cadc_core.requests, 'get', get):
         cadc_core.get_access_url.caps = {}
         assert 'http://my.org/mytap' == cadc_core.get_access_url('mytap')
-        assert 'https://www.cadc-ccda.hia-iha.nrc-cnrc.gc.ca/argus/tables' == \
-            cadc_core.get_access_url('mytap',
-                                     'ivo://ivoa.net/std/VOSI#tables-1.1')
+
+        # Remove this filter when https://github.com/astropy/astroquery/issues/2523 is fixed
+        with warnings.catch_warnings():
+            if XMLParsedAsHTMLWarning:
+                warnings.filterwarnings("ignore", category=XMLParsedAsHTMLWarning)
+
+            assert 'https://www.cadc-ccda.hia-iha.nrc-cnrc.gc.ca/argus/tables' == \
+                cadc_core.get_access_url('mytap', 'ivo://ivoa.net/std/VOSI#tables-1.1')
 
 
 @patch('astroquery.cadc.core.get_access_url',

setup.cfg

@@ -50,8 +50,6 @@ filterwarnings =
 # utils.commons.parse_coordinates, we should remove its usage:
     ignore:Coordinate string is being interpreted as an ICRS coordinate:astroquery.exceptions.InputWarning
     ignore:Coordinate string is being interpreted as an ICRS coordinate:UserWarning
-# To be removed with a fix for https://github.com/astropy/astroquery/issues/2523
-    ignore::bs4.builder.XMLParsedAsHTMLWarning
 # To be removed with a fix for https://github.com/astropy/astroquery/issues/2242
      ignore::astropy.io.votable.exceptions.E02
 # Warnings from yet to be refactored or to be removed modules